From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2018, #02; Tue, 17)
Date: Sun, 22 Apr 2018 13:17:55 -0700 [thread overview]
Message-ID: <20180422201755.GA92212@syl.local> (raw)
In-Reply-To: <xmqqzi22tlfx.fsf@gitster-ct.c.googlers.com>
On Tue, Apr 17, 2018 at 03:07:46PM +0900, Junio C Hamano wrote:
> * tb/config-type (2018-04-10) 2 commits
> - builtin/config.c: support `--type=<type>` as preferred alias for `--<type>`
> - builtin/config.c: treat type specifiers singularly
> (this branch is used by tb/config-default.)
>
> The "git config" command uses separate options e.g. "--int",
> "--bool", etc. to specify what type the caller wants the value to
> be interpreted as. A new "--type=<typename>" option has been
> introduced, which would make it cleaner to define new types.
>
> Expecting a final reroll.
> cf. <20180411034941.GA63158@syl.local>
> This looked more or less ready, IIRC
>
>
> * tb/config-default (2018-04-10) 3 commits
> - builtin/config: introduce `color` type specifier
> - config.c: introduce 'git_config_color' to parse ANSI colors
> - builtin/config: introduce `--default`
> (this branch uses tb/config-type.)
>
> "git config --get" learned the "--default" option, to help the
> calling script. Building on top of the tb/config-type topic, the
> "git config" learns "--type=color" type. Taken together, you can
> do things like "git config --get foo.color --default blue" and get
> the ANSI color sequence for the color given to foo.color variable,
> or "blue" if the variable does not exist.
>
> Will wait on the tb/config-type topic.
Hi Junio,
Thank you for picking up both of these topics. I sent a final reroll to
tb/config-type, which I see has made it successfully to 'pu'.
I noticed that tb/config-default, however, only landed two commits:
- builtin/config: introduce `color` type specifier
- config.c: introduce 'git_config_color' to parse ANSI colors
but not:
- builtin/config: introduce `--default`
As such, I am able to build on 'pu', but the `--default` option is
missing:
~/g/git (pu) $ ./git-config --type=color --default red core.doesntexist
error: unknown option `default'
Please advise.
Thanks,
Taylor
next prev parent reply other threads:[~2018-04-22 20:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 6:07 What's cooking in git.git (Apr 2018, #02; Tue, 17) Junio C Hamano
2018-04-17 14:04 ` Eric Sunshine
2018-04-17 18:05 ` Stefan Beller
2018-04-18 1:04 ` Junio C Hamano
2018-04-18 12:50 ` Derrick Stolee
2018-04-18 20:56 ` Junio C Hamano
2018-04-18 13:09 ` Jonathan Tan
2018-04-18 20:57 ` Junio C Hamano
2018-04-18 15:17 ` Christian Hesse
2018-04-18 21:00 ` Junio C Hamano
2018-04-18 19:39 ` Elijah Newren
2018-04-18 21:04 ` Junio C Hamano
2018-04-19 11:52 ` Sergey Organov
2018-04-20 22:18 ` js/rebase-recreate-merges, was " Johannes Schindelin
2018-04-22 20:17 ` Taylor Blau [this message]
2018-04-22 23:33 ` Junio C Hamano
2018-04-22 23:38 ` Taylor Blau
2018-04-23 13:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180422201755.GA92212@syl.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).