From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Apr 2018, #02; Tue, 17)
Date: Tue, 17 Apr 2018 11:05:59 -0700 [thread overview]
Message-ID: <CAGZ79kb=A6BsdrtH=2F0634+r5ejG9Ce9U0mry65jkNnscu1nA@mail.gmail.com> (raw)
In-Reply-To: <xmqqzi22tlfx.fsf@gitster-ct.c.googlers.com>
Hi Junio,
> --------------------------------------------------
> [New Topics]
> * sb/object-store-replace (2018-04-12) 15 commits
...
> The effort to pass the repository in-core structure throughout the
> API continues. This round deals with the code that implements the
> refs/replace/ mechanism.
>
> What's the doneness of this thing? I didn't recall seeing any
> response, especially ones that demonstrated the reviewer carefully
> read and thought about the issues surrounding the code. Not that I
> spotted any problems in these patches myself, though.
Stolee and Brandon provided a "quick LGTM" type of review
https://public-inbox.org/git/20180409232536.GB102627@google.com/
https://public-inbox.org/git/9ddfee7e-025a-79c9-8d6b-700c65a14067@gmail.com/
I do not recall an in depth review, though Rene had some design guidance
in form of a patch, which is also the first commit of the series
https://public-inbox.org/git/38962a15-1081-bbdb-b4c4-6b46222b5f64@web.de/
My plan was to build the next series on top this week while waiting for
further review, though I wonder how much review will happen this week.
(Brandon, Jonathan Tan and Jonathan Nieder are all OOO,
Peff is on vacation, too)
I do not recall any discussion worthy design discussions left over, so
I'd lean on "cook in next for a while".
>
> --------------------------------------------------
> [Cooking]
>
> * sb/blame-color (2018-04-17) 2 commits
> - builtin/blame: highlight recently changed lines
> - builtin/blame: dim uninteresting metadata lines
>
> "git blame" learns to unhighlight uninteresting metadata from the
> originating commit on lines that are the same as the previous one,
> and also paint lines in different colors depending on the age of
> the commit.
>
> The code to handle interaction between the config and command line
> option smelled fishy. Reviews and discussions are welcomed (not
> just to this topic but others too ;-).
I'll look at the replies in thread there.
> * sb/submodule-move-nested (2018-03-29) 6 commits
> - submodule: fixup nested submodules after moving the submodule
> - submodule-config: remove submodule_from_cache
> - submodule-config: add repository argument to submodule_from_{name, path}
> - submodule-config: allow submodule_free to handle arbitrary repositories
> - grep: remove "repo" arg from non-supporting funcs
> - submodule.h: drop declaration of connect_work_tree_and_git_dir
>
> Moving a submodule that itself has submodule in it with "git mv"
> forgot to make necessary adjustment to the nested sub-submodules;
> now the codepath learned to recurse into the submodules.
>
> What's the doneness of this thing?
I considered this done a long time ago,
"All 6 patches look good to me, thanks.
Reviewed-by: Jonathan Tan <jonathantanmy@google.com>"
https://public-inbox.org/git/20180328161727.af10f596dffc8e01205c41dd@google.com/
Thanks,
Stefan
next prev parent reply other threads:[~2018-04-17 18:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 6:07 What's cooking in git.git (Apr 2018, #02; Tue, 17) Junio C Hamano
2018-04-17 14:04 ` Eric Sunshine
2018-04-17 18:05 ` Stefan Beller [this message]
2018-04-18 1:04 ` Junio C Hamano
2018-04-18 12:50 ` Derrick Stolee
2018-04-18 20:56 ` Junio C Hamano
2018-04-18 13:09 ` Jonathan Tan
2018-04-18 20:57 ` Junio C Hamano
2018-04-18 15:17 ` Christian Hesse
2018-04-18 21:00 ` Junio C Hamano
2018-04-18 19:39 ` Elijah Newren
2018-04-18 21:04 ` Junio C Hamano
2018-04-19 11:52 ` Sergey Organov
2018-04-20 22:18 ` js/rebase-recreate-merges, was " Johannes Schindelin
2018-04-22 20:17 ` Taylor Blau
2018-04-22 23:33 ` Junio C Hamano
2018-04-22 23:38 ` Taylor Blau
2018-04-23 13:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kb=A6BsdrtH=2F0634+r5ejG9Ce9U0mry65jkNnscu1nA@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).