From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Stefan Beller <sbeller@google.com>
Cc: git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Apr 2018, #02; Tue, 17)
Date: Wed, 18 Apr 2018 08:50:10 -0400 [thread overview]
Message-ID: <287d6c83-2c7e-3138-def4-fee5d9cb9e48@gmail.com> (raw)
In-Reply-To: <xmqqpo2xjpf6.fsf@gitster-ct.c.googlers.com>
On 4/17/2018 9:04 PM, Junio C Hamano wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>>> What's the doneness of this thing? I didn't recall seeing any
>>> response, especially ones that demonstrated the reviewer carefully
>>> read and thought about the issues surrounding the code. Not that I
>>> spotted any problems in these patches myself, though.
>> Stolee and Brandon provided a "quick LGTM" type of review
>> https://public-inbox.org/git/20180409232536.GB102627@google.com/
>> https://public-inbox.org/git/9ddfee7e-025a-79c9-8d6b-700c65a14067@gmail.com/
> Yup. Giving positive reviews is harder than giving constructive
> criticism. Much harder.
>
> As readers cannot tell from a "quick LGTM" between "I didn't read it
> but it did not smell foul" and "I read it thoroughly, understood how
> the solution works, it was presented well, and agree with the design
> and implementation---there is nothing to add", the reviewers need to
> come up with some way to express that it is the latter case rather
> than the former.
>
> I would not claim that I've perfected my technique to do so, but
> when responding to such a "good" series, I rephrase the main idea in
> the series in my own words to show that I as a reviewer read the
> series well enough to be able to do so, perhaps with comparison with
> possible alternatives I could think of and dicussion to argue that
> the solution presented in the series is better, in an attempt to
> demonstrate that I am qualified to say "this one is good" with good
> enough understanding of both the issue the series addresses and the
> solution in the series.
I'm sorry that my second message was terse. My response to v1 [1] was
> I looked through these patches and only found one set of whitespace >
errors. Compiles and tests fine on my machine. > > Reviewed-by: Derrick
Stolee <dstolee@microsoft.com> So, I pulled the code, went through it
patch-by-patch, and saw that the transformations were made using the
established pattern. The second review was to chime in that my v1
comments had been addressed. Thanks, -Stolee
[1]
https://public-inbox.org/git/6c319100-df47-3b8d-8661-24e4643ada09@gmail.com/
next prev parent reply other threads:[~2018-04-18 12:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 6:07 What's cooking in git.git (Apr 2018, #02; Tue, 17) Junio C Hamano
2018-04-17 14:04 ` Eric Sunshine
2018-04-17 18:05 ` Stefan Beller
2018-04-18 1:04 ` Junio C Hamano
2018-04-18 12:50 ` Derrick Stolee [this message]
2018-04-18 20:56 ` Junio C Hamano
2018-04-18 13:09 ` Jonathan Tan
2018-04-18 20:57 ` Junio C Hamano
2018-04-18 15:17 ` Christian Hesse
2018-04-18 21:00 ` Junio C Hamano
2018-04-18 19:39 ` Elijah Newren
2018-04-18 21:04 ` Junio C Hamano
2018-04-19 11:52 ` Sergey Organov
2018-04-20 22:18 ` js/rebase-recreate-merges, was " Johannes Schindelin
2018-04-22 20:17 ` Taylor Blau
2018-04-22 23:33 ` Junio C Hamano
2018-04-22 23:38 ` Taylor Blau
2018-04-23 13:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=287d6c83-2c7e-3138-def4-fee5d9cb9e48@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).