git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
From: Jonathan Tan <jonathantanmy@google.com>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Apr 2018, #02; Tue, 17)
Date: Wed, 18 Apr 2018 06:09:47 -0700
Message-ID: <CAGf8dgLrWx0dNX5W=2_aonaG55jzhzOBTcr8u=36xSPvtVp8kQ@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kb=A6BsdrtH=2F0634+r5ejG9Ce9U0mry65jkNnscu1nA@mail.gmail.com>

On Tue, Apr 17, 2018 at 11:05 AM, Stefan Beller <sbeller@google.com> wrote:
>> * sb/submodule-move-nested (2018-03-29) 6 commits
>>  - submodule: fixup nested submodules after moving the submodule
>>  - submodule-config: remove submodule_from_cache
>>  - submodule-config: add repository argument to submodule_from_{name, path}
>>  - submodule-config: allow submodule_free to handle arbitrary repositories
>>  - grep: remove "repo" arg from non-supporting funcs
>>  - submodule.h: drop declaration of connect_work_tree_and_git_dir
>>
>>  Moving a submodule that itself has submodule in it with "git mv"
>>  forgot to make necessary adjustment to the nested sub-submodules;
>>  now the codepath learned to recurse into the submodules.
>>
>>  What's the doneness of this thing?
>
> I considered this done a long time ago,
>
>     "All 6 patches look good to me, thanks.
>      Reviewed-by: Jonathan Tan <jonathantanmy@google.com>"
>
> https://public-inbox.org/git/20180328161727.af10f596dffc8e01205c41dd@google.com/

To add to this, I sent this in reply to version 3 of this patch set,
after Stefan addressed my comments. Most of my in-depth comments were
in reply to version 1 of this patch, which are the grandchild replies
to [1].

[1] https://public-inbox.org/git/20180327213918.77851-1-sbeller@google.com/

  parent reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17  6:07 Junio C Hamano
2018-04-17 14:04 ` Eric Sunshine
2018-04-17 18:05 ` Stefan Beller
2018-04-18  1:04   ` Junio C Hamano
2018-04-18 12:50     ` Derrick Stolee
2018-04-18 20:56       ` Junio C Hamano
2018-04-18 13:09   ` Jonathan Tan [this message]
2018-04-18 20:57     ` Junio C Hamano
2018-04-18 15:17 ` Christian Hesse
2018-04-18 21:00   ` Junio C Hamano
2018-04-18 19:39 ` Elijah Newren
2018-04-18 21:04   ` Junio C Hamano
2018-04-19 11:52 ` Sergey Organov
2018-04-20 22:18 ` js/rebase-recreate-merges, was " Johannes Schindelin
2018-04-22 20:17 ` Taylor Blau
2018-04-22 23:33   ` Junio C Hamano
2018-04-22 23:38     ` Taylor Blau
2018-04-23 13:56       ` Junio C Hamano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGf8dgLrWx0dNX5W=2_aonaG55jzhzOBTcr8u=36xSPvtVp8kQ@mail.gmail.com' \
    --to=jonathantanmy@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox