From: Chris Packham <judge.packham@gmail.com>
To: git@vger.kernel.org
Cc: peff@peff.net, stefan.naewe@atlas-elektronik.com,
gitter.spiros@gmail.com, Chris Packham <judge.packham@gmail.com>
Subject: [RFC/PATCH] Makefile: suppress some cppcheck false-positives
Date: Fri, 16 Dec 2016 12:22:40 +1300 [thread overview]
Message-ID: <20161215232240.19427-1-judge.packham@gmail.com> (raw)
In-Reply-To: <20161214112401.mq3n5kui5eeebdtk@sigill.intra.peff.net>
Pass a list of suppressions to cppcheck so that legitimate errors are
more obvious.
Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
On Thu, Dec 15, 2016 at 12:24 AM, Jeff King <peff@peff.net> wrote:
> The patch itself is OK to me, I guess. The interesting part will be
> whether people start actually _using_ cppcheck and squelching the false
> positives. I'm not sure how I feel about the in-code annotations. I'd
> have to see a patch first.
So here's a patch that adds supression files. It would work well for
things in contrib/compat that don't change that often. It would be a
nightmare to maintain for high-touch code.
Makefile | 7 ++++++-
nedmalloc.supp | 4 ++++
regcomp.supp | 8 ++++++++
3 files changed, 18 insertions(+), 1 deletion(-)
create mode 100644 nedmalloc.supp
create mode 100644 regcomp.supp
diff --git a/Makefile b/Makefile
index e5c86decf..bb335ca0f 100644
--- a/Makefile
+++ b/Makefile
@@ -2637,7 +2637,12 @@ cover_db_html: cover_db
.PHONY: cppcheck
-CPPCHECK_FLAGS = --force --quiet --inline-suppr $(if $(CPPCHECK_ADD),--enable=$(CPPCHECK_ADD))
+CPPCHECK_SUPP = --suppressions-list=nedmalloc.supp \
+ --suppressions-list=regcomp.supp
+
+CPPCHECK_FLAGS = --force --quiet --inline-suppr \
+ $(if $(CPPCHECK_ADD),--enable=$(CPPCHECK_ADD)) \
+ $(CPPCHECK_SUPP)
cppcheck:
@cppcheck --version
diff --git a/nedmalloc.supp b/nedmalloc.supp
new file mode 100644
index 000000000..37bd54def
--- /dev/null
+++ b/nedmalloc.supp
@@ -0,0 +1,4 @@
+nullPointer:compat/nedmalloc/malloc.c.h:4093
+nullPointer:compat/nedmalloc/malloc.c.h:4106
+memleak:compat/nedmalloc/malloc.c.h:4646
+
diff --git a/regcomp.supp b/regcomp.supp
new file mode 100644
index 000000000..3ae023c26
--- /dev/null
+++ b/regcomp.supp
@@ -0,0 +1,8 @@
+memleak:compat/regex/regcomp.c:3086
+memleak:compat/regex/regcomp.c:3634
+memleak:compat/regex/regcomp.c:3086
+memleak:compat/regex/regcomp.c:3634
+uninitvar:compat/regex/regcomp.c:2802
+uninitvar:compat/regex/regcomp.c:2805
+memleak:compat/regex/regcomp.c:532
+
--
2.11.0.24.ge6920cf
next prev parent reply other threads:[~2016-12-15 23:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 9:22 [RFC/PATCH] Makefile: add cppcheck target Chris Packham
2016-12-13 9:32 ` Chris Packham
2016-12-13 9:37 ` stefan.naewe
2016-12-13 12:15 ` Jeff King
2016-12-13 12:28 ` Jeff King
2016-12-14 8:23 ` Chris Packham
2016-12-14 8:33 ` Chris Packham
2016-12-14 11:18 ` Jeff King
2016-12-14 9:27 ` [RFC/PATCHv2] " Chris Packham
2016-12-14 11:24 ` Jeff King
2016-12-14 14:46 ` Jeff King
2016-12-15 23:22 ` Chris Packham [this message]
2016-12-16 18:43 ` [RFC/PATCH] Makefile: suppress some cppcheck false-positives Junio C Hamano
2016-12-16 22:16 ` Jeff King
[not found] ` <6ABA4AA4-BD5C-4178-BB3B-91CA045EA2AD@gmail.com>
2016-12-17 7:31 ` [RFC/PATCHv2] Makefile: add cppcheck target Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215232240.19427-1-judge.packham@gmail.com \
--to=judge.packham@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
--cc=peff@peff.net \
--cc=stefan.naewe@atlas-elektronik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).