From: Jeff King <peff@peff.net>
To: Chris Packham <judge.packham@gmail.com>
Cc: git@vger.kernel.org, gitter.spiros@gmail.com
Subject: Re: [RFC/PATCH] Makefile: add cppcheck target
Date: Tue, 13 Dec 2016 07:15:10 -0500 [thread overview]
Message-ID: <20161213121510.5o5axuwzztbxcvfd@sigill.intra.peff.net> (raw)
In-Reply-To: <20161213092225.15299-1-judge.packham@gmail.com>
On Tue, Dec 13, 2016 at 10:22:25PM +1300, Chris Packham wrote:
> $ make cppcheck
> cppcheck --force --quiet --inline-suppr .
> [compat/nedmalloc/malloc.c.h:4093]: (error) Possible null pointer dereference: sp
> [compat/nedmalloc/malloc.c.h:4106]: (error) Possible null pointer dereference: sp
> [compat/nedmalloc/nedmalloc.c:551]: (error) Expression '*(&p.mycache)=TlsAlloc(),TLS_OUT_OF_INDEXES==*(&p.mycache)' depends on order of evaluation of side effects
> [compat/regex/regcomp.c:3086]: (error) Memory leak: sbcset
> [compat/regex/regcomp.c:3634]: (error) Memory leak: sbcset
> [compat/regex/regcomp.c:3086]: (error) Memory leak: mbcset
> [compat/regex/regcomp.c:3634]: (error) Memory leak: mbcset
> [compat/regex/regcomp.c:2802]: (error) Uninitialized variable: table_size
> [compat/regex/regcomp.c:2805]: (error) Uninitialized variable: table_size
> [compat/regex/regcomp.c:532]: (error) Memory leak: fastmap
> [t/t4051/appended1.c:3]: (error) Invalid number of character '{' when these macros are defined: ''.
> [t/t4051/appended2.c:35]: (error) Invalid number of character '{' when these macros are defined: ''.
>
> The last 2 are just false positives from test data. I haven't looked
> into any of the others.
I think these last two are a good sign that we need to be feeding the
list of source files to cppcheck. I tried your patch and it also started
looking in t/perf/build, which are old versions of git built to serve
the performance-testing suite.
See the way that the "tags" target is handled for a possible approach.
My main complaint with any static checker is how we can handle false
positives. I think our use of "-Wall -Werror" is successful because it's
not too hard to keep the normal state to zero warnings. Looking at the
output of cppcheck on my system (which is different than on yours!), I
do see a few real problems, but many false positives, too.
Unfortunately, one of the false positives is:
int foo = foo;
to silence -Wuninitialized, which causes cppcheck to complain that "foo"
is uninitialized. I'm worried we will end up with two static checkers
fighting each other, and no good way to please both.
-Peff
next prev parent reply other threads:[~2016-12-13 12:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 9:22 [RFC/PATCH] Makefile: add cppcheck target Chris Packham
2016-12-13 9:32 ` Chris Packham
2016-12-13 9:37 ` stefan.naewe
2016-12-13 12:15 ` Jeff King [this message]
2016-12-13 12:28 ` Jeff King
2016-12-14 8:23 ` Chris Packham
2016-12-14 8:33 ` Chris Packham
2016-12-14 11:18 ` Jeff King
2016-12-14 9:27 ` [RFC/PATCHv2] " Chris Packham
2016-12-14 11:24 ` Jeff King
2016-12-14 14:46 ` Jeff King
2016-12-15 23:22 ` [RFC/PATCH] Makefile: suppress some cppcheck false-positives Chris Packham
2016-12-16 18:43 ` Junio C Hamano
2016-12-16 22:16 ` Jeff King
[not found] ` <6ABA4AA4-BD5C-4178-BB3B-91CA045EA2AD@gmail.com>
2016-12-17 7:31 ` [RFC/PATCHv2] Makefile: add cppcheck target Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213121510.5o5axuwzztbxcvfd@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).