From: Jeff King <peff@peff.net>
To: Chris Packham <judge.packham@gmail.com>
Cc: git@vger.kernel.org, stefan.naewe@atlas-elektronik.com,
gitter.spiros@gmail.com
Subject: Re: [RFC/PATCHv2] Makefile: add cppcheck target
Date: Wed, 14 Dec 2016 06:24:01 -0500 [thread overview]
Message-ID: <20161214112401.mq3n5kui5eeebdtk@sigill.intra.peff.net> (raw)
In-Reply-To: <20161214092731.29076-1-judge.packham@gmail.com>
On Wed, Dec 14, 2016 at 10:27:31PM +1300, Chris Packham wrote:
> Changes in v2:
> - only run over actual git source files.
> - omit any files in t/
I actually wonder if FIND_SOURCE_FILES should be taking care of the "t/"
thing. I think "make tags" finds tags in t4051/appended1.c, which is
just silly.
> - introduce CPPCHECK_FLAGS which can be overridden in the make command
> line. This also uses a GNU make-ism to allow CPPCHECK_ADD to specify
> additional checks to be enabled.
The GNU-ism is fine; we already require GNU make to build.
The patch itself is OK to me, I guess. The interesting part will be
whether people start actually _using_ cppcheck and squelching the false
positives. I'm not sure how I feel about the in-code annotations. I'd
have to see a patch first.
-Peff
next prev parent reply other threads:[~2016-12-14 11:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 9:22 [RFC/PATCH] Makefile: add cppcheck target Chris Packham
2016-12-13 9:32 ` Chris Packham
2016-12-13 9:37 ` stefan.naewe
2016-12-13 12:15 ` Jeff King
2016-12-13 12:28 ` Jeff King
2016-12-14 8:23 ` Chris Packham
2016-12-14 8:33 ` Chris Packham
2016-12-14 11:18 ` Jeff King
2016-12-14 9:27 ` [RFC/PATCHv2] " Chris Packham
2016-12-14 11:24 ` Jeff King [this message]
2016-12-14 14:46 ` Jeff King
2016-12-15 23:22 ` [RFC/PATCH] Makefile: suppress some cppcheck false-positives Chris Packham
2016-12-16 18:43 ` Junio C Hamano
2016-12-16 22:16 ` Jeff King
[not found] ` <6ABA4AA4-BD5C-4178-BB3B-91CA045EA2AD@gmail.com>
2016-12-17 7:31 ` [RFC/PATCHv2] Makefile: add cppcheck target Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214112401.mq3n5kui5eeebdtk@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
--cc=judge.packham@gmail.com \
--cc=stefan.naewe@atlas-elektronik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).