From: Jeff King <peff@peff.net>
To: Kevin Daudt <me@ikke.info>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC 0/1] mailinfo: de-quote quoted-pair in header fields
Date: Thu, 15 Sep 2016 00:18:23 -0700 [thread overview]
Message-ID: <20160915071822.dpfgg7yldtzar4b2@sigill.intra.peff.net> (raw)
In-Reply-To: <20160915051533.GC26893@ikke.info>
On Thu, Sep 15, 2016 at 07:15:33AM +0200, Kevin Daudt wrote:
> > > Another small thing I am not sure about is if the \ quoting can hide
> > > an embedded newline in the author name. Would we end up turning
> > >
> > > From: "Jeff \
> > > King" <peff@peff.net>
> > >
> > > or somesuch into
> > >
> > > Author: Jeff
> > > King
> > > Email: peff@peff.net
> > >
> > > ;-)
> >
> > Heh, yeah. That is another reason to clean up and sanitize as much as
> > possible before stuffing it into another text format that will be
> > parsed.
>
> A quoted string cannot contain newlines according to the RFC, so I think
> we don't need to care about that.
I wondered how we handled something like:
From: =?UTF-8?q?J=0Aff=20King?= <peff@peff.net>
which sticks a newline into the middle of the buffer. We do decode it
that way, but eventually call cleanup_space() which converts a run of 1
or more isspace() characters into a single space (0x20). So you end up
with:
Author: J ff King
which is probably reasonable.
> Makes sense, the current itteration of my patch already strips exterior
> quotes, no matter where they happen.
>
> I will send a patch soon.
Great. Thanks for working on this.
-Peff
next prev parent reply other threads:[~2016-09-15 7:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 20:10 git-am includes escape characters from 'From' field Swift Geek
2016-09-13 15:26 ` Jeff King
2016-09-13 23:46 ` [RFC 0/1] de-quote quoted-strings in mailinfo Kevin Daudt
2016-09-13 23:46 ` [RFC 0/1] mailinfo: de-quote quoted-pair in header fields Kevin Daudt
2016-09-14 0:04 ` Junio C Hamano
2016-09-14 4:58 ` Kevin Daudt
2016-09-14 5:09 ` Jeff King
2016-09-14 5:54 ` Junio C Hamano
2016-09-14 16:03 ` Kevin Daudt
2016-09-14 17:43 ` Junio C Hamano
2016-09-14 19:17 ` Jeff King
2016-09-14 19:30 ` Junio C Hamano
2016-09-14 19:38 ` Jeff King
2016-09-15 5:15 ` Kevin Daudt
2016-09-15 7:18 ` Jeff King [this message]
2016-09-14 5:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915071822.dpfgg7yldtzar4b2@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ikke.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).