From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kevin Daudt <me@ikke.info>, git@vger.kernel.org
Subject: Re: [RFC 0/1] mailinfo: de-quote quoted-pair in header fields
Date: Wed, 14 Sep 2016 12:38:20 -0700 [thread overview]
Message-ID: <20160914193819.ua5ubvbf5wz7tvuj@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqfup2qny9.fsf@gitster.mtv.corp.google.com>
On Wed, Sep 14, 2016 at 12:30:06PM -0700, Junio C Hamano wrote:
> Another small thing I am not sure about is if the \ quoting can hide
> an embedded newline in the author name. Would we end up turning
>
> From: "Jeff \
> King" <peff@peff.net>
>
> or somesuch into
>
> Author: Jeff
> King
> Email: peff@peff.net
>
> ;-)
Heh, yeah. That is another reason to clean up and sanitize as much as
possible before stuffing it into another text format that will be
parsed.
> So let's roll the \" -> " into mailinfo.
>
> I am not sure if we also should remove the surrounding "", i.e. we
> currently do not turn this
>
> From: "Jeff King" <peff@peff.net>
>
> into this:
>
> Author: Jeff King
> Email: peff@peff.net
>
> I think we probably should, and remove the one that does so from the
> reader.
I think you have to, or else you cannot tell the difference between
surrounding quotes that need to be stripped, and ones that were
backslash-escaped. Like:
From: "Jeff King" <peff@peff.net>
From: \"Jeff King\" <peff@peff.net>
which would both become:
Author: "Jeff King"
Email: peff@peff.net
though I am not sure the latter one is actually valid; you might need to
be inside syntactic quotes in order to include backslashed quotes. I
haven't read rfc2822 carefully recently enough to know.
Anyway, I think that:
From: One "Two \"Three\" Four" Five
may also be valid. So the quote-stripping in the reader is not just "at
the outside", but may need to handle interior syntactic quotes, too. So
it really makes sense for me to clean and sanitize as much as possible
in one step, and then make the parser of mailinfo as dumb as possible.
-Peff
next prev parent reply other threads:[~2016-09-14 19:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 20:10 git-am includes escape characters from 'From' field Swift Geek
2016-09-13 15:26 ` Jeff King
2016-09-13 23:46 ` [RFC 0/1] de-quote quoted-strings in mailinfo Kevin Daudt
2016-09-13 23:46 ` [RFC 0/1] mailinfo: de-quote quoted-pair in header fields Kevin Daudt
2016-09-14 0:04 ` Junio C Hamano
2016-09-14 4:58 ` Kevin Daudt
2016-09-14 5:09 ` Jeff King
2016-09-14 5:54 ` Junio C Hamano
2016-09-14 16:03 ` Kevin Daudt
2016-09-14 17:43 ` Junio C Hamano
2016-09-14 19:17 ` Jeff King
2016-09-14 19:30 ` Junio C Hamano
2016-09-14 19:38 ` Jeff King [this message]
2016-09-15 5:15 ` Kevin Daudt
2016-09-15 7:18 ` Jeff King
2016-09-14 5:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914193819.ua5ubvbf5wz7tvuj@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ikke.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).