From: Kevin Daudt <me@ikke.info>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC 0/1] mailinfo: de-quote quoted-pair in header fields
Date: Wed, 14 Sep 2016 06:58:41 +0200 [thread overview]
Message-ID: <20160914045841.GA26893@ikke.info> (raw)
In-Reply-To: <xmqqr38ns5wi.fsf@gitster.mtv.corp.google.com>
On Tue, Sep 13, 2016 at 05:04:45PM -0700, Junio C Hamano wrote:
> Kevin Daudt <me@ikke.info> writes:
>
>
> It often is easier to read if smaller of the two are in the if part
> and the larger in else part. Also your switch/case is indented one
> level too deep. I.e.
>
Thanks, I've switched the order and fixed indentation.
>
> I found the variable name "skip" a bit hard to reason about. What
> it does is to signal the next round of the processing that we have
> seen a single-byte quote and it should keep the byte it will get, no
> matter what its value is. It is "skipping" the conditional
> processing, but I'd imagine most people would consider it is
> "keeping the byte".
Yes, I agree and was trying to find a better name. I have renamed it to
"take_next_literally", which indicates better what it means.
>
> > @@ -461,6 +506,7 @@ static int check_header(struct mailinfo *mi,
> > */
> > strbuf_add(&sb, line->buf + len + 2, line->len - len - 2);
> > decode_header(mi, &sb);
> > + unescape_quoted_pair(mi, &sb);
> > handle_header(&hdr_data[i], &sb);
> > ret = 1;
> > goto check_header_out;
>
> I wonder why this call is only in here, not on other headers that
> all call decode_header(). For that matter, I wonder if the call (or
> the logic of the helper function itself) should go at the end of
> decode_header(). After all, this is different kind of decoding; the
> current one knows how to do b/q encoding but forgot about the more
> traditional quoting done with backslash, and you are teaching the
> code that the current decoding it does is insufficient and how to
> handle the one that the original implementors forgot about.
Makes sense, it should be applied to all headers (I missed the other
decode_header calls).
I will send a new version later.
next prev parent reply other threads:[~2016-09-14 4:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 20:10 git-am includes escape characters from 'From' field Swift Geek
2016-09-13 15:26 ` Jeff King
2016-09-13 23:46 ` [RFC 0/1] de-quote quoted-strings in mailinfo Kevin Daudt
2016-09-13 23:46 ` [RFC 0/1] mailinfo: de-quote quoted-pair in header fields Kevin Daudt
2016-09-14 0:04 ` Junio C Hamano
2016-09-14 4:58 ` Kevin Daudt [this message]
2016-09-14 5:09 ` Jeff King
2016-09-14 5:54 ` Junio C Hamano
2016-09-14 16:03 ` Kevin Daudt
2016-09-14 17:43 ` Junio C Hamano
2016-09-14 19:17 ` Jeff King
2016-09-14 19:30 ` Junio C Hamano
2016-09-14 19:38 ` Jeff King
2016-09-15 5:15 ` Kevin Daudt
2016-09-15 7:18 ` Jeff King
2016-09-14 5:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914045841.GA26893@ikke.info \
--to=me@ikke.info \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@lists.ikke.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).