From: Jeff King <peff@peff.net>
To: Swift Geek <swiftgeek@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-am includes escape characters from 'From' field
Date: Tue, 13 Sep 2016 08:26:23 -0700 [thread overview]
Message-ID: <20160913152622.2xtyn6mki6p6afsg@sigill.intra.peff.net> (raw)
In-Reply-To: <op.yno0zli7ig5ot5@localhost.localdomain>
On Mon, Sep 12, 2016 at 10:10:23PM +0200, Swift Geek wrote:
> git-am seems to add backslash that escapes double quote character, example
> git format-patch
>
> From 63da989a5295214f9bd06cd7b409a86a65241eea Mon Sep 17 00:00:00 2001
> From: "Sebastian \"Swift Geek\" Grzywna" <swiftgeek@gmail.com>
This looks correct; the output of format-patch is an rfc2822 message,
and it requires this quoting.
The part you don't show, and that I think is wrong, is that if you then
"git am" this patch, it pulls the backslashes into the commit object.
The culprit looks like "parse_mail()" in builtin/am.c (or possibly
mailinfo() that it calls), which blindly picks up the name portion
without doing any rfc2822 de-quoting.
I don't think we have any existing de-quoting routines to plug in, so
fixing it would probably start with writing one.
-Peff
next prev parent reply other threads:[~2016-09-13 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 20:10 git-am includes escape characters from 'From' field Swift Geek
2016-09-13 15:26 ` Jeff King [this message]
2016-09-13 23:46 ` [RFC 0/1] de-quote quoted-strings in mailinfo Kevin Daudt
2016-09-13 23:46 ` [RFC 0/1] mailinfo: de-quote quoted-pair in header fields Kevin Daudt
2016-09-14 0:04 ` Junio C Hamano
2016-09-14 4:58 ` Kevin Daudt
2016-09-14 5:09 ` Jeff King
2016-09-14 5:54 ` Junio C Hamano
2016-09-14 16:03 ` Kevin Daudt
2016-09-14 17:43 ` Junio C Hamano
2016-09-14 19:17 ` Jeff King
2016-09-14 19:30 ` Junio C Hamano
2016-09-14 19:38 ` Jeff King
2016-09-15 5:15 ` Kevin Daudt
2016-09-15 7:18 ` Jeff King
2016-09-14 5:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913152622.2xtyn6mki6p6afsg@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=swiftgeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).