From: Adam Spiers <git@adamspiers.org>
To: git@vger.kernel.org
Subject: Re: as/check-ignore (was Re: What's cooking in git.git (Jan 2013, #02; Thu, 3))
Date: Sun, 6 Jan 2013 16:17:58 +0000 [thread overview]
Message-ID: <20130106161758.GC2396@pacific.linksys.moosehall> (raw)
In-Reply-To: <7vobh4tzx3.fsf@alter.siamese.dyndns.org>
On Fri, Jan 04, 2013 at 01:13:12PM -0800, Junio C Hamano wrote:
> Adam Spiers <git@adamspiers.org> writes:
> > On Thu, Jan 3, 2013 at 7:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
> >> * as/check-ignore (2012-12-28) 19 commits
> >> - Add git-check-ignore sub-command
> >> - setup.c: document get_pathspec()
> >> - pathspec.c: extract new validate_path() for reuse
> >> - pathspec.c: move reusable code from builtin/add.c
> >> - add.c: remove unused argument from validate_pathspec()
> >> - add.c: refactor treat_gitlinks()
> >> - dir.c: provide clear_directory() for reclaiming dir_struct memory
> >> - dir.c: keep track of where patterns came from
> >> - dir.c: use a single struct exclude_list per source of excludes
> >> - dir.c: rename free_excludes() to clear_exclude_list()
> >> - dir.c: refactor is_path_excluded()
> >> - dir.c: refactor is_excluded()
> >> - dir.c: refactor is_excluded_from_list()
> >> - dir.c: rename excluded() to is_excluded()
> >> - dir.c: rename excluded_from_list() to is_excluded_from_list()
> >> - dir.c: rename path_excluded() to is_path_excluded()
> >> - dir.c: rename cryptic 'which' variable to more consistent name
> >> - Improve documentation and comments regarding directory traversal API
> >> - api-directory-listing.txt: update to match code
> >>
> >> Rerolled. The early parts looked mostly fine; we may want to split
> >> this into two topics and have the early half graduate sooner.
> >
> > Sounds good to me. As already mentioned, I have the v4 series ready
> > and it addresses all issues already voiced in v3, but I have postponed
> > submitting it as per your request. Please let me know when and how to
> > proceed, thanks!
>
> I was planning to add a new "as/dir-c-cleanup" topic that leads to
> f619881 (dir.c: rename free_excludes() to clear_exclude_list(),
> 2012-12-27), and leave the remainder in this series. I think the
> earlier parts of this series up to that point should go 'next' now.
That sounds perfect; thanks. I'll rebase v4 on top of this and submit.
next prev parent reply other threads:[~2013-01-06 16:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 19:17 What's cooking in git.git (Jan 2013, #02; Thu, 3) Junio C Hamano
2013-01-04 17:23 ` Adam Spiers
2013-01-04 21:13 ` as/check-ignore (was Re: What's cooking in git.git (Jan 2013, #02; Thu, 3)) Junio C Hamano
2013-01-06 16:17 ` Adam Spiers [this message]
2013-01-06 16:58 ` [PATCH v4 00/11] new git check-ignore sub-command Adam Spiers
2013-01-06 16:58 ` [PATCH v4 01/11] dir.c: use a single struct exclude_list per source of excludes Adam Spiers
2013-01-06 16:58 ` [PATCH v4 02/11] dir.c: keep track of where patterns came from Adam Spiers
2013-01-06 16:58 ` [PATCH v4 03/11] dir.c: provide clear_directory() for reclaiming dir_struct memory Adam Spiers
2013-01-06 16:58 ` [PATCH v4 04/11] dir.c: improve docs for match_pathspec() and match_pathspec_depth() Adam Spiers
2013-01-06 16:58 ` [PATCH v4 05/11] add.c: remove unused argument from validate_pathspec() Adam Spiers
2013-01-06 16:58 ` [PATCH v4 06/11] add.c: move pathspec matchers into new pathspec.c for reuse Adam Spiers
2013-01-06 16:58 ` [PATCH v4 07/11] pathspec.c: rename newly public functions for clarity Adam Spiers
2013-01-06 16:58 ` [PATCH v4 08/11] add.c: extract check_path_for_gitlink() from treat_gitlinks() for reuse Adam Spiers
2013-01-06 16:58 ` [PATCH v4 09/11] add.c: extract new die_if_path_beyond_symlink() " Adam Spiers
2013-01-06 16:58 ` [PATCH v4 10/11] setup.c: document get_pathspec() Adam Spiers
2013-01-06 16:58 ` [PATCH v4 11/11] add git-check-ignore sub-command Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130106161758.GC2396@pacific.linksys.moosehall \
--to=git@adamspiers.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).