git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Adam Spiers <git@adamspiers.org>
To: git list <git@vger.kernel.org>
Subject: [PATCH v4 05/11] add.c: remove unused argument from validate_pathspec()
Date: Sun,  6 Jan 2013 16:58:07 +0000	[thread overview]
Message-ID: <1357491493-11619-6-git-send-email-git@adamspiers.org> (raw)
In-Reply-To: <1357491493-11619-1-git-send-email-git@adamspiers.org>

The 'argc' argument passed to validate_pathspec() was never used.

Signed-off-by: Adam Spiers <git@adamspiers.org>
---
 builtin/add.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/builtin/add.c b/builtin/add.c
index c689f37..1f62ba3 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -197,7 +197,7 @@ static void refresh(int verbose, const char **pathspec)
         free(seen);
 }
 
-static const char **validate_pathspec(int argc, const char **argv, const char *prefix)
+static const char **validate_pathspec(const char **argv, const char *prefix)
 {
 	const char **pathspec = get_pathspec(prefix, argv);
 
@@ -248,7 +248,7 @@ int interactive_add(int argc, const char **argv, const char *prefix, int patch)
 	const char **pathspec = NULL;
 
 	if (argc) {
-		pathspec = validate_pathspec(argc, argv, prefix);
+		pathspec = validate_pathspec(argv, prefix);
 		if (!pathspec)
 			return -1;
 	}
@@ -414,7 +414,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)
 		fprintf(stderr, _("Maybe you wanted to say 'git add .'?\n"));
 		return 0;
 	}
-	pathspec = validate_pathspec(argc, argv, prefix);
+	pathspec = validate_pathspec(argv, prefix);
 
 	if (read_cache() < 0)
 		die(_("index file corrupt"));
-- 
1.7.11.7.33.gb8feba5

  parent reply	other threads:[~2013-01-06 16:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 19:17 What's cooking in git.git (Jan 2013, #02; Thu, 3) Junio C Hamano
2013-01-04 17:23 ` Adam Spiers
2013-01-04 21:13   ` as/check-ignore (was Re: What's cooking in git.git (Jan 2013, #02; Thu, 3)) Junio C Hamano
2013-01-06 16:17     ` Adam Spiers
2013-01-06 16:58       ` [PATCH v4 00/11] new git check-ignore sub-command Adam Spiers
2013-01-06 16:58         ` [PATCH v4 01/11] dir.c: use a single struct exclude_list per source of excludes Adam Spiers
2013-01-06 16:58         ` [PATCH v4 02/11] dir.c: keep track of where patterns came from Adam Spiers
2013-01-06 16:58         ` [PATCH v4 03/11] dir.c: provide clear_directory() for reclaiming dir_struct memory Adam Spiers
2013-01-06 16:58         ` [PATCH v4 04/11] dir.c: improve docs for match_pathspec() and match_pathspec_depth() Adam Spiers
2013-01-06 16:58         ` Adam Spiers [this message]
2013-01-06 16:58         ` [PATCH v4 06/11] add.c: move pathspec matchers into new pathspec.c for reuse Adam Spiers
2013-01-06 16:58         ` [PATCH v4 07/11] pathspec.c: rename newly public functions for clarity Adam Spiers
2013-01-06 16:58         ` [PATCH v4 08/11] add.c: extract check_path_for_gitlink() from treat_gitlinks() for reuse Adam Spiers
2013-01-06 16:58         ` [PATCH v4 09/11] add.c: extract new die_if_path_beyond_symlink() " Adam Spiers
2013-01-06 16:58         ` [PATCH v4 10/11] setup.c: document get_pathspec() Adam Spiers
2013-01-06 16:58         ` [PATCH v4 11/11] add git-check-ignore sub-command Adam Spiers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357491493-11619-6-git-send-email-git@adamspiers.org \
    --to=git@adamspiers.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).