From: Adam Spiers <git@adamspiers.org>
To: git list <git@vger.kernel.org>
Subject: [PATCH v4 00/11] new git check-ignore sub-command
Date: Sun, 6 Jan 2013 16:58:02 +0000 [thread overview]
Message-ID: <1357491493-11619-1-git-send-email-git@adamspiers.org> (raw)
In-Reply-To: <20130106161758.GC2396@pacific.linksys.moosehall>
This is the v4 re-roll of the check-ignore series, which is based on
Junio's as/dir-c-cleanup topic branch f6198812 (dir.c: rename
free_excludes() to clear_exclude_list(), 2012-12-27). As previously
discussed, the earlier parts of the v3 series seem to be complete and
are progressing to 'next'.
Since v3, I addressed the issue of newly public functions with
unacceptably vague or generic names via the following steps:
- eliminated extraction from add.c to pathspec.c of two functions
which did not need to be public (validate_pathspec() and
treat_gitlinks())
- edited the series history to create separate commits for
extraction of reusable code from treat_gitlinks() and
validate_pathspec() into more carefully named public functions
This should make reviewing easier.
I will summarise the changes in the revised patches since v3 in
between the "---" divider and the diffstat of each individual patch.
This series is also available via the check-ignore-v4 tag in:
git://github.com/aspiers/git.git
Adam Spiers (11):
dir.c: use a single struct exclude_list per source of excludes
dir.c: keep track of where patterns came from
dir.c: provide clear_directory() for reclaiming dir_struct memory
dir.c: improve docs for match_pathspec() and match_pathspec_depth()
add.c: remove unused argument from validate_pathspec()
add.c: move pathspec matchers into new pathspec.c for reuse
pathspec.c: rename newly public functions for clarity
add.c: extract check_path_for_gitlink() from treat_gitlinks() for
reuse
add.c: extract new die_if_path_beyond_symlink() for reuse
setup.c: document get_pathspec()
add git-check-ignore sub-command
.gitignore | 1 +
Documentation/git-check-ignore.txt | 89 +++
Documentation/gitignore.txt | 6 +-
Documentation/technical/api-directory-listing.txt | 14 +-
Makefile | 3 +
builtin.h | 1 +
builtin/add.c | 78 +--
builtin/check-ignore.c | 173 ++++++
builtin/clean.c | 3 +-
builtin/ls-files.c | 9 +-
command-list.txt | 1 +
contrib/completion/git-completion.bash | 1 +
dir.c | 152 ++++--
dir.h | 62 ++-
git.c | 1 +
pathspec.c | 101 ++++
pathspec.h | 9 +
setup.c | 19 +
t/t0008-ignores.sh | 632 ++++++++++++++++++++++
unpack-trees.c | 2 +-
20 files changed, 1240 insertions(+), 117 deletions(-)
create mode 100644 Documentation/git-check-ignore.txt
create mode 100644 builtin/check-ignore.c
create mode 100644 pathspec.c
create mode 100644 pathspec.h
create mode 100755 t/t0008-ignores.sh
--
1.7.11.7.33.gb8feba5
next prev parent reply other threads:[~2013-01-06 16:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 19:17 What's cooking in git.git (Jan 2013, #02; Thu, 3) Junio C Hamano
2013-01-04 17:23 ` Adam Spiers
2013-01-04 21:13 ` as/check-ignore (was Re: What's cooking in git.git (Jan 2013, #02; Thu, 3)) Junio C Hamano
2013-01-06 16:17 ` Adam Spiers
2013-01-06 16:58 ` Adam Spiers [this message]
2013-01-06 16:58 ` [PATCH v4 01/11] dir.c: use a single struct exclude_list per source of excludes Adam Spiers
2013-01-06 16:58 ` [PATCH v4 02/11] dir.c: keep track of where patterns came from Adam Spiers
2013-01-06 16:58 ` [PATCH v4 03/11] dir.c: provide clear_directory() for reclaiming dir_struct memory Adam Spiers
2013-01-06 16:58 ` [PATCH v4 04/11] dir.c: improve docs for match_pathspec() and match_pathspec_depth() Adam Spiers
2013-01-06 16:58 ` [PATCH v4 05/11] add.c: remove unused argument from validate_pathspec() Adam Spiers
2013-01-06 16:58 ` [PATCH v4 06/11] add.c: move pathspec matchers into new pathspec.c for reuse Adam Spiers
2013-01-06 16:58 ` [PATCH v4 07/11] pathspec.c: rename newly public functions for clarity Adam Spiers
2013-01-06 16:58 ` [PATCH v4 08/11] add.c: extract check_path_for_gitlink() from treat_gitlinks() for reuse Adam Spiers
2013-01-06 16:58 ` [PATCH v4 09/11] add.c: extract new die_if_path_beyond_symlink() " Adam Spiers
2013-01-06 16:58 ` [PATCH v4 10/11] setup.c: document get_pathspec() Adam Spiers
2013-01-06 16:58 ` [PATCH v4 11/11] add git-check-ignore sub-command Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357491493-11619-1-git-send-email-git@adamspiers.org \
--to=git@adamspiers.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).