list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: "Randall S. Becker" <>
To: "'Junio C Hamano'" <>
Cc:, "'Torsten Bögershausen'" <>,
	"'Lars Schneider'" <>
Subject: RE: [PATCH] Fixed pervasive enumeration warning in convert.h.
Date: Fri, 12 Jan 2018 14:52:50 -0500	[thread overview]
Message-ID: <004c01d38bde$f0e6bb50$d2b431f0$> (raw)
In-Reply-To: <>

> From: Junio C Hamano []
On January 12, 2018 2:25 PM, Junio C Hamano wrote:
> > From: "Randall S. Becker" <>
> >  {
> > -	return convert_to_git(istate, path, NULL, 0, NULL, 0);
> > +	return convert_to_git(istate, path, NULL, 0, NULL,
> >  }
> I think this is being solved a bit differently with a1fbf854
> ("convert_to_git(): safe_crlf/checksafe becomes int conv_flags", 2018-01-
> 06), and 0 becomes the right value to pass at this caller to say "I am passing
> none of the flag bit".
> I am hoping that the series that ends at f3b11d54 ("convert: add support for
> 'checkout-encoding' attribute", 2018-01-06) will be rerolled and hit 'master'
> early in the next cycle.

Got it. Will revert this one on my end. On a related too many warnings subject, hashmap.h has a variable unused (void *item). Is that addressed soon? If not, I can deal with it.

(also, sorry about the other email address in use. It's the only way I can use send-email, fixing the annoying prior wrapping/tab/space garbage I had).

  reply	other threads:[~2018-01-12 19:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 16:36 randall.s.becker
2018-01-12 19:25 ` Junio C Hamano
2018-01-12 19:52   ` Randall S. Becker [this message]
2018-01-13 17:13     ` unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.] René Scharfe
2018-01-13 17:30       ` Randall S. Becker
2018-01-13 22:49   ` [PATCH v1 1/1] convert_to_git(): safe_crlf/checksafe becomes int conv_flags tboegi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004c01d38bde$f0e6bb50$d2b431f0$' \ \ \ \ \ \
    --subject='RE: [PATCH] Fixed pervasive enumeration warning in convert.h.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for project(s) associated with this inbox:

AGPL code for this site: git clone