list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
Cc: "Randall S. Becker" <>
Subject: [PATCH] Fixed pervasive enumeration warning in convert.h.
Date: Fri, 12 Jan 2018 11:36:44 -0500	[thread overview]
Message-ID: <> (raw)

From: "Randall S. Becker" <>

The actual enum value should be used rather than 0 and was causing
a warning in an inline proc.

Signed-off-by: Randall S. Becker <>
 convert.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/convert.h b/convert.h
index 4f2da22..a9a6658 100644
--- a/convert.h
+++ b/convert.h
@@ -79,7 +79,7 @@ extern int renormalize_buffer(const struct index_state *istate,
 static inline int would_convert_to_git(const struct index_state *istate,
 				       const char *path)
-	return convert_to_git(istate, path, NULL, 0, NULL, 0);
+	return convert_to_git(istate, path, NULL, 0, NULL, SAFE_CRLF_FALSE);
 /* Precondition: would_convert_to_git_filter_fd(path) == true */
 extern void convert_to_git_filter_fd(const struct index_state *istate,

             reply	other threads:[~2018-01-12 16:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 16:36 randall.s.becker [this message]
2018-01-12 19:25 ` Junio C Hamano
2018-01-12 19:52   ` Randall S. Becker
2018-01-13 17:13     ` unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.] René Scharfe
2018-01-13 17:30       ` Randall S. Becker
2018-01-13 22:49   ` [PATCH v1 1/1] convert_to_git(): safe_crlf/checksafe becomes int conv_flags tboegi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH] Fixed pervasive enumeration warning in convert.h.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for project(s) associated with this inbox:

AGPL code for this site: git clone