From: Junio C Hamano <gitster@pobox.com>
To: randall.s.becker@rogers.com
Cc: git@vger.kernel.org, "Randall S. Becker" <rsbecker@nexbridge.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Lars Schneider" <larsxschneider@gmail.com>
Subject: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.
Date: Fri, 12 Jan 2018 11:25:00 -0800 [thread overview]
Message-ID: <xmqqh8rqx4kz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20180112163644.14108-1-randall.s.becker@rogers.com> (randall s. becker's message of "Fri, 12 Jan 2018 11:36:44 -0500")
randall.s.becker@rogers.com writes:
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> The actual enum value should be used rather than 0 and was causing
> a warning in an inline proc.
>
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
> convert.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/convert.h b/convert.h
> index 4f2da22..a9a6658 100644
> --- a/convert.h
> +++ b/convert.h
> @@ -79,7 +79,7 @@ extern int renormalize_buffer(const struct index_state *istate,
> static inline int would_convert_to_git(const struct index_state *istate,
> const char *path)
> {
> - return convert_to_git(istate, path, NULL, 0, NULL, 0);
> + return convert_to_git(istate, path, NULL, 0, NULL, SAFE_CRLF_FALSE);
> }
I think this is being solved a bit differently with a1fbf854
("convert_to_git(): safe_crlf/checksafe becomes int conv_flags",
2018-01-06), and 0 becomes the right value to pass at this caller to
say "I am passing none of the flag bit".
I am hoping that the series that ends at f3b11d54 ("convert: add
support for 'checkout-encoding' attribute", 2018-01-06) will be
rerolled and hit 'master' early in the next cycle.
Thanks.
next prev parent reply other threads:[~2018-01-12 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 16:36 [PATCH] Fixed pervasive enumeration warning in convert.h randall.s.becker
2018-01-12 19:25 ` Junio C Hamano [this message]
2018-01-12 19:52 ` Randall S. Becker
2018-01-13 17:13 ` unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.] René Scharfe
2018-01-13 17:30 ` Randall S. Becker
2018-01-13 22:49 ` [PATCH v1 1/1] convert_to_git(): safe_crlf/checksafe becomes int conv_flags tboegi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh8rqx4kz.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=randall.s.becker@rogers.com \
--cc=rsbecker@nexbridge.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).