git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'René Scharfe'" <l.s.r@web.de>
Cc: "'Junio C Hamano'" <gitster@pobox.com>,
	git@vger.kernel.org, "'Torsten Bögershausen'" <tboegi@web.de>,
	"'Lars Schneider'" <larsxschneider@gmail.com>,
	"'Jeff Hostetler'" <jeffhost@microsoft.com>
Subject: RE: unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.]
Date: Sat, 13 Jan 2018 12:30:35 -0500	[thread overview]
Message-ID: <002501d38c94$3b9efd00$b2dcf700$@nexbridge.com> (raw)
In-Reply-To: <f139ed79-1e12-d7b6-dd24-ce77000917ec@web.de>

> Sent: On January 13, 2018 12:13 PM, René Scharfe wrote:
> Am 12.01.2018 um 20:52 schrieb Randall S. Becker:
> > On a related too many warnings subject, hashmap.h has a variable
> > unused (void *item). Is that addressed soon? If not, I can deal with
> > it.
> Here are the code lines containing the variable in question:
> 
>         void *item;
>         while ((item = hashmap_iter_next(&iter)))
> 
> Intriguing.  The variable "item" is set, but can be removed without effect.
> GCC 7.2 and Clang 5 don't warn about that.
> 
> The code was introduced by 8b604d1951 (hashmap: add API to disable item
> counting when threaded) and there is no patch in pu that touches it again,

I was thinking about just changing it to the following and submitting the trivial patch:

         while (hashmap_iter_next(&iter))

Avoids the frame allocation of void *item so should make it minimally faster when compiled without optimization. 

Cheers,
Randall


  reply	other threads:[~2018-01-13 17:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 16:36 [PATCH] Fixed pervasive enumeration warning in convert.h randall.s.becker
2018-01-12 19:25 ` Junio C Hamano
2018-01-12 19:52   ` Randall S. Becker
2018-01-13 17:13     ` unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.] René Scharfe
2018-01-13 17:30       ` Randall S. Becker [this message]
2018-01-13 22:49   ` [PATCH v1 1/1] convert_to_git(): safe_crlf/checksafe becomes int conv_flags tboegi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002501d38c94$3b9efd00$b2dcf700$@nexbridge.com' \
    --to=rsbecker@nexbridge.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    --cc=l.s.r@web.de \
    --cc=larsxschneider@gmail.com \
    --cc=tboegi@web.de \
    --subject='RE: unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git
	nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git
	nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git