bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH] lib/gettext.h: fix warning if gettext is already present
Date: Mon, 27 Jan 2020 20:29:26 +0100	[thread overview]
Message-ID: <7353597.sKBQ19CNnG@omega> (raw)
In-Reply-To: <fc91addb-5418-aef6-145e-26acd8831229@benettiengineering.com>

Giulio Benetti wrote:
> > There should not be a <gettext.h> in public include file directories!
> 
> Indeed there is not, there is <libintl.h> and it is part of uclibc:
> https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/include/libintl.h

Ah! Most of the contents of this <libintl.h> is OK. But
  - gettext_noop
  - gettext_printf
don't belong there.

> What I was proposing at the beginning was to add:
> #undef gettext_noop
> 
> the same way uClibc does.

The compiler warning about a redefined macros is meant to catch unintentional
overriding definitions. For example, when a program defines gettext_noop
and afterwards #includes "gettext.h". It is reasonable to keep this warning
in the general case.

Therefore the right action is that the uClibc people remove their definition
of gettext_noop and gettext_printf from this file.

Bruno



  reply	other threads:[~2020-01-27 19:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-26 18:19 [PATCH] lib/gettext.h: fix warning if gettext is already present Giulio Benetti
2020-01-26 22:12 ` Bruno Haible
2020-01-26 22:47   ` Giulio Benetti
2020-01-26 22:50     ` Giulio Benetti
2020-01-27  1:41     ` Bruno Haible
2020-01-27 16:00       ` Giulio Benetti
2020-01-27 17:38         ` Bruno Haible
2020-01-27 18:02           ` Giulio Benetti
2020-01-27 19:29             ` Bruno Haible [this message]
2020-02-02 23:15               ` Giulio Benetti
2020-02-03  1:07                 ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7353597.sKBQ19CNnG@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=giulio.benetti@benettiengineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).