From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3A38F1F466 for ; Mon, 27 Jan 2020 19:29:40 +0000 (UTC) Received: from localhost ([::1]:49968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwA4o-0001no-OU for normalperson@yhbt.net; Mon, 27 Jan 2020 14:29:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55247) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwA4j-0001hq-23 for bug-gnulib@gnu.org; Mon, 27 Jan 2020 14:29:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwA4h-0003Yj-Qe for bug-gnulib@gnu.org; Mon, 27 Jan 2020 14:29:32 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::7]:30152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iwA4h-0003SA-5a for bug-gnulib@gnu.org; Mon, 27 Jan 2020 14:29:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1580153367; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=ArZdNsIPWfNHoCWMI3AjOy/VEWrfbjgc6Mb6zSP0H8s=; b=Nvj0WV5vobQ/AciYtUQb5DKjOwT4OIgbLFdUP3TujzblJM2ZsOCm+m7ojWWkJt07Lz 2ilwgx8ss50+fHailaqg8LpIg3NhlOEJAmnJYNN2xxEORJmeSihXAUrKVJ+KG1VaMqYS YJmW4uF+F5JzG487fodmiiF4Ru9AI276U8QPbSzdn+TJ0u4g2/6elBG+MuFoBVtWPhDy unYyZMWlEbQcgWQeXTY9XLFEcoBMBZc2waIvV2UXYil+wFXrJIDgYaVbWEKQiwTtQeIz vlmy/25sQwjYziwT2N39S2+6PH0cSg54GMh6sy3EJ6bMcPXqa1L5F6oCHJXlfYY5cFF/ xP2A== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOH6fzxfs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.1.7 DYNA|AUTH) with ESMTPSA id d0b1daw0RJTRHUV (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Mon, 27 Jan 2020 20:29:27 +0100 (CET) From: Bruno Haible To: Giulio Benetti Subject: Re: [PATCH] lib/gettext.h: fix warning if gettext is already present Date: Mon, 27 Jan 2020 20:29:26 +0100 Message-ID: <7353597.sKBQ19CNnG@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-171-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <20200126181929.38457-1-giulio.benetti@benettiengineering.com> <2484654.CyytvBT3bq@omega> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::7 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Giulio Benetti wrote: > > There should not be a in public include file directories! > > Indeed there is not, there is and it is part of uclibc: > https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/include/libintl.h Ah! Most of the contents of this is OK. But - gettext_noop - gettext_printf don't belong there. > What I was proposing at the beginning was to add: > #undef gettext_noop > > the same way uClibc does. The compiler warning about a redefined macros is meant to catch unintentional overriding definitions. For example, when a program defines gettext_noop and afterwards #includes "gettext.h". It is reasonable to keep this warning in the general case. Therefore the right action is that the uClibc people remove their definition of gettext_noop and gettext_printf from this file. Bruno