From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Subject: Re: [PATCH] lib/gettext.h: fix warning if gettext is already present
Date: Sun, 26 Jan 2020 23:47:48 +0100 [thread overview]
Message-ID: <d3c6c285-394e-7c96-8dd8-ef935c51c58c@benettiengineering.com> (raw)
In-Reply-To: <1852089.F2OspKUfUd@omega>
Hi Bruno,
On 1/26/20 11:12 PM, Bruno Haible wrote:
> Hi Giulio,
>
>> Building on an environment where gettext is already present leads to
>> emitting a warning about gettext_noop() alread defined.
>
> Where is the first definition of gettext_noop located? In another copy
> of gettext.h? In a third-party .h file? Or in the .c file that is being
> compiled?
In a entire gettext. In my specific case I'm adding package libbytesize
[1], where they add src/gettext.h but they define ENABLE_NLS in any case
[2]. Maybe configure.ac should define it or not according to gettext
presence... What do you think?
Here I've opened a pull request:
https://github.com/storaged-project/libbytesize/pull/64
The goal is to add libbytesize to Buildroot.
[1]: https://github.com/storaged-project/libbytesize
[2]:
https://github.com/storaged-project/libbytesize/blob/master/configure.ac#L21
--
Giulio Benetti
Benetti Engineering sas
> Bruno
>
>
next prev parent reply other threads:[~2020-01-26 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 18:19 [PATCH] lib/gettext.h: fix warning if gettext is already present Giulio Benetti
2020-01-26 22:12 ` Bruno Haible
2020-01-26 22:47 ` Giulio Benetti [this message]
2020-01-26 22:50 ` Giulio Benetti
2020-01-27 1:41 ` Bruno Haible
2020-01-27 16:00 ` Giulio Benetti
2020-01-27 17:38 ` Bruno Haible
2020-01-27 18:02 ` Giulio Benetti
2020-01-27 19:29 ` Bruno Haible
2020-02-02 23:15 ` Giulio Benetti
2020-02-03 1:07 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3c6c285-394e-7c96-8dd8-ef935c51c58c@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).