From: Bruno Haible <bruno@clisp.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH] lib/gettext.h: fix warning if gettext is already present
Date: Mon, 27 Jan 2020 18:38:29 +0100 [thread overview]
Message-ID: <2484654.CyytvBT3bq@omega> (raw)
In-Reply-To: <c9bbe71c-1372-6006-823d-592f2655fb37@benettiengineering.com>
Giulio Benetti wrote:
> > Since you reported a redefinition warning regarding 'gettext_noop',
> > gettext_noop must have been defined as a macro already elsewhere. Where?
>
> gettext_noop() is defined in environment gettext.h
What do you mean by "environment gettext.h"??
The documentation [1] says
"Do not install the gettext.h file in public locations. Every package
that needs it should contain a copy of it on its own."
There should not be a <gettext.h> in public include file directories!
> and in
> libbytesize/configure.ac they define:
> CFLAGS="${CFLAGS} -DENABLE_NLS"
> ...
> libbytesize should define ENABLE_NLS according to host gettext presence
This is perfectly OK. It implies that their package won't compile if
gettext() is not contained in libc or GNU gettext was not installed.
But it is NOT the cause of the warning that you are seeing.
> the problem to be fixed is in libbytesize and
> it's not fixed by the PR I've already open, I need to modify
> configure.ac to emit ENABLE_NLS according to host gettext presence.
No, libbytesize is OK.
> only once, it's enough to see gettext_noop() redefined, since it's
> defined in host.
The "host" that you are alluding to is the problem.
Bruno
[1] https://www.gnu.org/software/gettext/manual/html_node/lib_002fgettext_002eh.html
next prev parent reply other threads:[~2020-01-27 17:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 18:19 [PATCH] lib/gettext.h: fix warning if gettext is already present Giulio Benetti
2020-01-26 22:12 ` Bruno Haible
2020-01-26 22:47 ` Giulio Benetti
2020-01-26 22:50 ` Giulio Benetti
2020-01-27 1:41 ` Bruno Haible
2020-01-27 16:00 ` Giulio Benetti
2020-01-27 17:38 ` Bruno Haible [this message]
2020-01-27 18:02 ` Giulio Benetti
2020-01-27 19:29 ` Bruno Haible
2020-02-02 23:15 ` Giulio Benetti
2020-02-03 1:07 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2484654.CyytvBT3bq@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=giulio.benetti@benettiengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).