bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
* fix incorrect 'Link' sections
@ 2019-01-04 19:26 Bruno Haible
  0 siblings, 0 replies; only message in thread
From: Bruno Haible @ 2019-01-04 19:26 UTC (permalink / raw)
  To: bug-gnulib

Another incorrect 'Link' section is the one in the 'regex' module:
- It needs to inherit the link directive from the 'lock' module.
  This is needed on AIX 7 (and probably on HP-UX 11.11, see the
  earlier report [1][2]).
- It also needs a reference to libintl. (Reported in [3].)

Paul's patch in response to [1][2] fixed the regex-tests module.
The $(LIB_PTHREAD) addition, however, is redundant: None of the
dependencies of the 'regex-tests' module sets a LIB_PTHREAD variable;
therefore this reference expands to empty.

[1] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00052.html
[2] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00054.html
[3] http://lists.gnu.org/archive/html/bug-gnulib/2013-02/msg00003.html


2019-01-04  Bruno Haible  <bruno@clisp.org>

	Fix incorrect 'Link' sections.
	* modules/regex (Link): Mention the link requirement of module 'lock'.
	* modules/regex-tests (Makefile.am): Don't use LIB_PTHREAD.

diff --git a/modules/regex b/modules/regex
index 278510c..7f50916 100644
--- a/modules/regex
+++ b/modules/regex
@@ -48,6 +48,7 @@ Include:
 <regex.h>
 
 Link:
+$(LTLIBTHREAD) when linking with libtool, $(LIBTHREAD) otherwise
 $(LTLIBINTL) when linking with libtool, $(LIBINTL) otherwise
 
 License:
diff --git a/modules/regex-tests b/modules/regex-tests
index 30ca5fd..0782303 100644
--- a/modules/regex-tests
+++ b/modules/regex-tests
@@ -11,4 +11,4 @@ configure.ac:
 Makefile.am:
 TESTS += test-regex
 check_PROGRAMS += test-regex
-test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD) $(LIB_PTHREAD)
+test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD)



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-01-04 19:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 19:26 fix incorrect 'Link' sections Bruno Haible

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).