From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: fix incorrect 'Link' sections
Date: Fri, 04 Jan 2019 20:26:48 +0100 [thread overview]
Message-ID: <4298654.OBUZQ0IIEE@omega> (raw)
Another incorrect 'Link' section is the one in the 'regex' module:
- It needs to inherit the link directive from the 'lock' module.
This is needed on AIX 7 (and probably on HP-UX 11.11, see the
earlier report [1][2]).
- It also needs a reference to libintl. (Reported in [3].)
Paul's patch in response to [1][2] fixed the regex-tests module.
The $(LIB_PTHREAD) addition, however, is redundant: None of the
dependencies of the 'regex-tests' module sets a LIB_PTHREAD variable;
therefore this reference expands to empty.
[1] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00052.html
[2] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00054.html
[3] http://lists.gnu.org/archive/html/bug-gnulib/2013-02/msg00003.html
2019-01-04 Bruno Haible <bruno@clisp.org>
Fix incorrect 'Link' sections.
* modules/regex (Link): Mention the link requirement of module 'lock'.
* modules/regex-tests (Makefile.am): Don't use LIB_PTHREAD.
diff --git a/modules/regex b/modules/regex
index 278510c..7f50916 100644
--- a/modules/regex
+++ b/modules/regex
@@ -48,6 +48,7 @@ Include:
<regex.h>
Link:
+$(LTLIBTHREAD) when linking with libtool, $(LIBTHREAD) otherwise
$(LTLIBINTL) when linking with libtool, $(LIBINTL) otherwise
License:
diff --git a/modules/regex-tests b/modules/regex-tests
index 30ca5fd..0782303 100644
--- a/modules/regex-tests
+++ b/modules/regex-tests
@@ -11,4 +11,4 @@ configure.ac:
Makefile.am:
TESTS += test-regex
check_PROGRAMS += test-regex
-test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD) $(LIB_PTHREAD)
+test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD)
reply other threads:[~2019-01-04 19:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4298654.OBUZQ0IIEE@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).