From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 208.118.235.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 867EA1F6A9 for ; Fri, 4 Jan 2019 19:26:55 +0000 (UTC) Received: from localhost ([127.0.0.1]:38344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfV7O-0003Hw-B1 for normalperson@yhbt.net; Fri, 04 Jan 2019 14:26:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfV7L-0003Hr-9o for bug-gnulib@gnu.org; Fri, 04 Jan 2019 14:26:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfV7K-0005nE-DJ for bug-gnulib@gnu.org; Fri, 04 Jan 2019 14:26:51 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::4]:19160) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gfV7J-0005eL-S3 for bug-gnulib@gnu.org; Fri, 04 Jan 2019 14:26:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1546630008; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=Slsugd1GWs9kZV/fZDm8cUQONmIsb4HjJiquMZjjxvE=; b=mSRrhbDu8EzadJTREWrYb907VrMZ2hbDNcA/RcqJBrRlTsr5eW9uoUvP8lINOs5UBl gNELdRw8m1OxVLsxB4iIjRnEQcGSvKik9britoM0qm8eSNae5nBbjgUAw/22vs4f1xon pbzkj22dK/icyr6bhgd6DfjUetYPTPuwAWUEgDpa90HfrVhxYpYJIkrJ7YpWc4esDoY4 KbL8r5N8LzL/TtnIZPvJdGYOTeJj8Xbb0mfm5rW0huqUoxEePdisx6Vf/+b/muxsZ583 0nm9JpL8hORzeVLZuUQS8iDpdyyBH3FPMmSGk0TIpkb4rQXFOBsZiXYOs8RGjkv8AJwz SpJA== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGKf2y/s=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH) with ESMTPSA id v0a34ev04JQm3CQ (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Fri, 4 Jan 2019 20:26:48 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Subject: fix incorrect 'Link' sections Date: Fri, 04 Jan 2019 20:26:48 +0100 Message-ID: <4298654.OBUZQ0IIEE@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::4 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Another incorrect 'Link' section is the one in the 'regex' module: - It needs to inherit the link directive from the 'lock' module. This is needed on AIX 7 (and probably on HP-UX 11.11, see the earlier report [1][2]). - It also needs a reference to libintl. (Reported in [3].) Paul's patch in response to [1][2] fixed the regex-tests module. The $(LIB_PTHREAD) addition, however, is redundant: None of the dependencies of the 'regex-tests' module sets a LIB_PTHREAD variable; therefore this reference expands to empty. [1] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00052.html [2] http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00054.html [3] http://lists.gnu.org/archive/html/bug-gnulib/2013-02/msg00003.html 2019-01-04 Bruno Haible Fix incorrect 'Link' sections. * modules/regex (Link): Mention the link requirement of module 'lock'. * modules/regex-tests (Makefile.am): Don't use LIB_PTHREAD. diff --git a/modules/regex b/modules/regex index 278510c..7f50916 100644 --- a/modules/regex +++ b/modules/regex @@ -48,6 +48,7 @@ Include: Link: +$(LTLIBTHREAD) when linking with libtool, $(LIBTHREAD) otherwise $(LTLIBINTL) when linking with libtool, $(LIBINTL) otherwise License: diff --git a/modules/regex-tests b/modules/regex-tests index 30ca5fd..0782303 100644 --- a/modules/regex-tests +++ b/modules/regex-tests @@ -11,4 +11,4 @@ configure.ac: Makefile.am: TESTS += test-regex check_PROGRAMS += test-regex -test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD) $(LIB_PTHREAD) +test_regex_LDADD = $(LDADD) @LIBINTL@ $(LIBTHREAD)