From: Bruno Haible <bruno@clisp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>, bug-gnulib@gnu.org
Subject: Re: warnings in unit tests
Date: Thu, 10 Jun 2021 22:05:32 +0200 [thread overview]
Message-ID: <3760922.z8YlfvkdsK@omega> (raw)
In-Reply-To: <20210609004102.GA18692@altlinux.org>
Dmitry V. Levin wrote:
> Unlike many other gcc warnings, -Wmissing-prototypes is especially useful
> because it doesn't report false positives, so I don't see why one may want
> to turn -Wmissing-prototypes off.
Sometimes a function in a test is not used on some platforms. What are the
possible ways to deal with it?
(1) The test function could be put into a #if. This #if condition needs
to be updated in some circumstances.
=> This approach (which I would use in lib/ code) is not zero-cost.
(2) The test function can be made 'static'; then we get a compiler warning
about an unused function (already with '-Wall', IIRC).
(3) The test function can be made global; then we have no warning.
But -Wmissing-prototypes makes it into a warning.
(4) Then we need to add a prototype to fix that warning.
You see my point? These are small considerations each time, but they
contribute to making test authoring+maintenance a hassle. And they have
no benefit (as I said, in a test that consists of a single compilation
unit, linked against one or more .a files).
Bruno
next prev parent reply other threads:[~2021-06-10 20:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 17:01 new module 'sigsegv' Bruno Haible
2021-06-06 23:27 ` Dmitry V. Levin
2021-06-07 0:49 ` Bruno Haible
2021-06-07 10:29 ` Dmitry V. Levin
2021-06-08 1:45 ` Jim Meyering
2021-06-08 2:40 ` warnings in unit tests Bruno Haible
2021-06-08 5:55 ` Jim Meyering
2021-06-08 8:56 ` Bruno Haible
2021-06-09 0:41 ` Dmitry V. Levin
2021-06-10 20:05 ` Bruno Haible [this message]
[not found] ` <CAH8yC8kHTq5J9onJj+2jwy_DwzXrwujqFs9TEBxGh5k_KCu=kg@mail.gmail.com>
2021-06-08 10:57 ` Bruno Haible
2021-06-08 16:42 ` Paul Eggert
2021-06-09 13:35 ` Dmitry V. Levin
2021-06-09 19:38 ` Bruno Haible
2021-06-10 19:39 ` Bruno Haible
2021-06-09 7:23 ` Bernhard Voelker
2021-06-09 14:17 ` Bruno Haible
2021-06-10 8:13 ` Simon Josefsson via Gnulib discussion list
2021-06-10 19:51 ` Bruno Haible
2021-06-10 21:49 ` Simon Josefsson via Gnulib discussion list
2021-06-11 12:21 ` Eric Blake
2021-06-11 13:57 ` Bruno Haible
2021-06-19 12:02 ` new module 'sigsegv' Bruno Haible
2021-06-21 18:22 ` [PATCH] sigsegv, sigsegv-tests: Assign my contributions to the FSF Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2024-04-28 6:52 Pacify -Wmissing-variable-declarations in unit tests Collin Funk
2024-04-28 23:27 ` Paul Eggert
2024-04-29 0:58 ` Collin Funk
2024-04-29 22:12 ` warnings " Bruno Haible
2024-04-30 0:31 ` Collin Funk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3760922.z8YlfvkdsK@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=ldv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).