From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Bruno Haible <bruno@clisp.org>, Jim Meyering <jim@meyering.net>
Cc: bug-gnulib@gnu.org
Subject: Re: new module 'sigsegv'
Date: Mon, 7 Jun 2021 13:29:32 +0300 [thread overview]
Message-ID: <20210607102932.GA24455@altlinux.org> (raw)
In-Reply-To: <2263638.MxO8Z3q26L@omega>
Hi,
On Mon, Jun 07, 2021 at 02:49:35AM +0200, Bruno Haible wrote:
[...]
> > -volatile int *
> > +static volatile int *
> > recurse_1 (int n, volatile int *p)
> > {
> > if (n < INT_MAX)
> > @@ -80,7 +80,7 @@ recurse_1 (int n, volatile int *p)
> > return p;
> > }
> >
> > -int
> > +static int
> > recurse (volatile int n)
> > {
> > return *recurse_1 (n, &n);
>
> This part should better not be applied. It may enable compiler optimizations
> (now or in the future) that, in the end, turn an endless recursion into an
> endless loop.
I'm not sure there is any difference left in the modern world of
lto-enabled compilers. Anyway, in most cases warnings issued by
-Wmissing-prototypes are not related to functions with volatile return
types, so making them static shouldn't affect the result.
> > @@ -183,6 +183,9 @@ main ()
> > *(volatile int *) (page + 0x678) = 42;
> > break;
> > case 3:
> > +#if 6 < __GNUC__
> > +# pragma GCC diagnostic ignored "-Wnull-dereference"
> > +#endif
> > *(volatile int *) 0 = 42;
> > break;
> > case 4:
>
> We shouldn't spend time eliminating warnings from test code.
>
> The goal is to have a good coverage of the lib/* code with unit tests.
> That means, we need to
> - make it easy to write unit tests,
> - not make it time-consuming to maintain them.
>
> Eliminating warnings from lib/* code is useful, to avoid bugs in the
> programs. But eliminating warnings from tests/* code goes against the
> goal of increasing test coverage.
>
> I think the right fix would be that gnulib-tool's --import/--update
> option, when creating a tests directory, adds a $(CFLAG_ALLOW_WARNING)
> to tests/Makefile.am, where CFLAG_ALLOW_WARNING is defined as
> -Wno-error when the compiler is GCC or clang,
> empty otherwise
> Will that work in GNU grep?
GNU grep explicitly disables some warnings and enables -Werror for gnulib
tests [1][2], so I'd like to ask Jim what's the preferred way of handling
this in GNU grep.
[1] https://git.savannah.gnu.org/gitweb/?p=grep.git;a=commitdiff;h=v3.6-2-g623008c
[2] https://git.savannah.gnu.org/gitweb/?p=grep.git;a=commitdiff;h=v3.6-17-g74cda43
--
ldv
next prev parent reply other threads:[~2021-06-07 10:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 17:01 new module 'sigsegv' Bruno Haible
2021-06-06 23:27 ` Dmitry V. Levin
2021-06-07 0:49 ` Bruno Haible
2021-06-07 10:29 ` Dmitry V. Levin [this message]
2021-06-08 1:45 ` Jim Meyering
2021-06-08 2:40 ` warnings in unit tests Bruno Haible
2021-06-08 5:55 ` Jim Meyering
2021-06-08 8:56 ` Bruno Haible
2021-06-09 0:41 ` Dmitry V. Levin
2021-06-10 20:05 ` Bruno Haible
[not found] ` <CAH8yC8kHTq5J9onJj+2jwy_DwzXrwujqFs9TEBxGh5k_KCu=kg@mail.gmail.com>
2021-06-08 10:57 ` Bruno Haible
2021-06-08 16:42 ` Paul Eggert
2021-06-09 13:35 ` Dmitry V. Levin
2021-06-09 19:38 ` Bruno Haible
2021-06-10 19:39 ` Bruno Haible
2021-06-09 7:23 ` Bernhard Voelker
2021-06-09 14:17 ` Bruno Haible
2021-06-10 8:13 ` Simon Josefsson via Gnulib discussion list
2021-06-10 19:51 ` Bruno Haible
2021-06-10 21:49 ` Simon Josefsson via Gnulib discussion list
2021-06-11 12:21 ` Eric Blake
2021-06-11 13:57 ` Bruno Haible
2021-06-19 12:02 ` new module 'sigsegv' Bruno Haible
2021-06-21 18:22 ` [PATCH] sigsegv, sigsegv-tests: Assign my contributions to the FSF Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607102932.GA24455@altlinux.org \
--to=ldv@altlinux.org \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).