From: Collin Funk <collin.funk1@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>, Bruno Haible <bruno@clisp.org>,
bug-gnulib@gnu.org
Subject: Re: Pacify -Wmissing-variable-declarations in unit tests.
Date: Sun, 28 Apr 2024 17:58:43 -0700 [thread overview]
Message-ID: <10c966f9-34aa-40fd-8659-6075098b0006@gmail.com> (raw)
In-Reply-To: <d4565b0f-ed11-493d-8a64-de59419336d5@cs.ucla.edu>
Hi Paul,
On 4/28/24 4:27 PM, Paul Eggert wrote:
> For test cases this is more a judgment call, but I prefer doing either
> the above or adjusting the warning flags, to ignoring warnings, as the
> other warnings can be useful at time.
Yeah, I could see these warnings making it hard to see ones that
actually matter. Lets see what Bruno thinks.
The patch in the original email should contain all of the variables
that trigger it. If we decide to follow the coding style you mentioned
I can make all the obvious ones static, i.e. checking for variables
being defined in gnulib headers.
Collin
next prev parent reply other threads:[~2024-04-29 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 6:52 Pacify -Wmissing-variable-declarations in unit tests Collin Funk
2024-04-28 10:11 ` Bruno Haible
2024-04-28 11:03 ` Collin Funk
2024-04-28 23:27 ` Paul Eggert
2024-04-29 0:58 ` Collin Funk [this message]
2024-04-29 22:12 ` warnings " Bruno Haible
2024-04-30 0:31 ` Collin Funk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10c966f9-34aa-40fd-8659-6075098b0006@gmail.com \
--to=collin.funk1@gmail.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).