From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Bruno Haible <bruno@clisp.org>
Cc: bug-gnulib@gnu.org, Jim Meyering <jim@meyering.net>
Subject: Re: warnings in unit tests
Date: Wed, 9 Jun 2021 03:41:02 +0300 [thread overview]
Message-ID: <20210609004102.GA18692@altlinux.org> (raw)
In-Reply-To: <2086778.xA2Ij3oMRU@omega>
On Tue, Jun 08, 2021 at 10:56:33AM +0200, Bruno Haible wrote:
> Jim Meyering wrote:
> > I can live without -Wmissing-prototypes in gnulib tests, but I still
> > remember times where using that option exposed a real bug.
>
> -Wmissing-prototypes typically exposes real bugs when a program is composed
> of several compilation units. Unit tests are typically a single compilation
> unit plus libtests.a, and libtests.a being built from modules with .h / .c
> combinations it does not have the kind of bug that -Wmissing-prototypes can
> detect.
Unlike many other gcc warnings, -Wmissing-prototypes is especially useful
because it doesn't report false positives, so I don't see why one may want
to turn -Wmissing-prototypes off.
In case of recurse_1(), the function isn't declared static for a specific
reason that isn't obvious for casual readers. In such cases it's usually
a good idea to add a comment explaining why this case is different from
the common pattern.
--
ldv
next prev parent reply other threads:[~2021-06-09 0:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 17:01 new module 'sigsegv' Bruno Haible
2021-06-06 23:27 ` Dmitry V. Levin
2021-06-07 0:49 ` Bruno Haible
2021-06-07 10:29 ` Dmitry V. Levin
2021-06-08 1:45 ` Jim Meyering
2021-06-08 2:40 ` warnings in unit tests Bruno Haible
2021-06-08 5:55 ` Jim Meyering
2021-06-08 8:56 ` Bruno Haible
2021-06-09 0:41 ` Dmitry V. Levin [this message]
2021-06-10 20:05 ` Bruno Haible
[not found] ` <CAH8yC8kHTq5J9onJj+2jwy_DwzXrwujqFs9TEBxGh5k_KCu=kg@mail.gmail.com>
2021-06-08 10:57 ` Bruno Haible
2021-06-08 16:42 ` Paul Eggert
2021-06-09 13:35 ` Dmitry V. Levin
2021-06-09 19:38 ` Bruno Haible
2021-06-10 19:39 ` Bruno Haible
2021-06-09 7:23 ` Bernhard Voelker
2021-06-09 14:17 ` Bruno Haible
2021-06-10 8:13 ` Simon Josefsson via Gnulib discussion list
2021-06-10 19:51 ` Bruno Haible
2021-06-10 21:49 ` Simon Josefsson via Gnulib discussion list
2021-06-11 12:21 ` Eric Blake
2021-06-11 13:57 ` Bruno Haible
2021-06-19 12:02 ` new module 'sigsegv' Bruno Haible
2021-06-21 18:22 ` [PATCH] sigsegv, sigsegv-tests: Assign my contributions to the FSF Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609004102.GA18692@altlinux.org \
--to=ldv@altlinux.org \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).