From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org, Collin Funk <collin.funk1@gmail.com>
Subject: Re: Refactoring rewrite_filename functions
Date: Wed, 17 Apr 2024 03:35:34 +0200 [thread overview]
Message-ID: <26909173.d79VK8dOqj@nimes> (raw)
In-Reply-To: <4f567b55-2b44-48a3-9cdb-1a8a9570d589@gmail.com>
Hi Collin,
> I'm thinking of making this function accept a single filename instead
> of a list
Makes sense, as previously discussed.
> and then moving it to GLConfig.
This does not make sense. GLConfig is meant to hold settings and configuration,
nothing more.
I see the home of this function more in GLFileSystem.py. Maybe in class
GLFileAssistant, maybe in a new class in that same file.
> Also, there is a similar section of code to this new function in
> main.py line 1313 under "mode == 'copy-file'", but it is missing the
> 'tests=lib/' replacement. Would there be a way to simplify that too?
> The use of 'tests=lib/' is escaping my mind at the moment...
'tests=lib/' should not occur in the scope of mode == 'copy-file'.
But this string is an indicator inside gnulib-tool; users of gnulib-tool
should not be allowed to pass it.
Bruno
next prev parent reply other threads:[~2024-04-17 1:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 1:23 gnulib-tool.py: Remove a redundant function Collin Funk
2024-04-15 2:20 ` Collin Funk
2024-04-15 14:58 ` Bruno Haible
2024-04-15 15:24 ` Collin Funk
2024-04-16 15:09 ` Bruno Haible
2024-04-16 16:23 ` Collin Funk
2024-04-17 1:12 ` Refactoring rewrite_filename functions Collin Funk
2024-04-17 1:35 ` Bruno Haible [this message]
2024-04-17 2:08 ` Collin Funk
2024-04-17 14:03 ` Bruno Haible
2024-04-15 11:47 ` gnulib-tool.py: Remove a redundant function Bruno Haible
2024-04-15 14:07 ` Collin Funk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26909173.d79VK8dOqj@nimes \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=collin.funk1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).