From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 283871F44D for ; Wed, 17 Apr 2024 01:35:58 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=dvlHzFhh; dkim=fail reason="signature verification failed" header.d=clisp.org header.i=@clisp.org header.a=ed25519-sha256 header.s=strato-dkim-0003 header.b=zZsKJKdq; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwuD9-0007eS-Gc; Tue, 16 Apr 2024 21:35:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwuD7-0007eB-Fi for bug-gnulib@gnu.org; Tue, 16 Apr 2024 21:35:41 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.216]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwuD5-0006JQ-1X for bug-gnulib@gnu.org; Tue, 16 Apr 2024 21:35:41 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1713317734; cv=none; d=strato.com; s=strato-dkim-0002; b=YkTUWv2ZRg2fvDQljQkwbcDQ4MGj0AAnSPSBAm6I43Jy9qy1Gr3qYJwJ9wSL+BmHpZ WAr2BslmTuHrGc+IGFtLhkiu7CstX/GR1GczOAAzzOLqwW0wVWzoadpxwjfoD4HcShwv o0NbBS4kveaK38LA171sAvVZxpMzKr7tsmNo0u9qO10jUQssIgXcFev83wZnQK13xx5H r6cMRXqQzdglJp+oz4H9yEZCKShRjc1n//36Cx8cCGLnxq1AGZBkY1vdebSc4MXX+t9k V3zC2TCdieLKOLNTDFocJmcX/99kOMV2iIHRd7WyLhiO1F2M1Y7X3SqA4aUs6ehph38V +MRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1713317734; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=fDLvqjqJKjyDOPBaZE9j7ZwV4xQSKhQzdj8TpSluM3Q=; b=qKmCPHFpAK0nUO5BodAyLDK4dehQ+vCA+dv3pX3WjvXWR4SJFbQaUvlfxgXgpjqIMF YQdL/NXFhgZtiVGbWoUWv+IBTNVCbiA8XT1kIQ46NcRmhJHz/dNiCiqpbR31Btux+Grv /z7Eez2jS2ojZ4exq89iPsGpgFJEIfAouvs5m01cJZxodi1PgAsa+GGDQLGA1XjiaaDu 3IO4/ZLsPCsmKzaGWtST7WPzfQTrh8aqfVgPPBhYRbuKfCQ4s3jWgT/P2gWISqGRL2sg VM1TdfRZNryOzN9GqtJCAjHPB19grMDQgxtFCQp5wPA4EZV73HhEMUTJVyHkkZv1TOdX 8hRw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1713317734; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=fDLvqjqJKjyDOPBaZE9j7ZwV4xQSKhQzdj8TpSluM3Q=; b=dvlHzFhhNt6Cf31Zbs4iBKOZQpibKZQcOkdRhEZAG47PsoQEjiHDEB6Gj4mjqwwHXi dBgPgq2q2AqxohSoDjQE55uAFcnSKC6GtV4hNF4OeZuUZ+jKLqI2GqQLeKirwov4eqgh sfVCnw+yi2Ok4l1GXNN7cI6vcwHzNsKKAKe4A7DwBHbPpn+Ow2a3Mfk/+wgYPOq794/v UEC8/CcPPIiyxzFtn8PM6Qtzxo7BVaQ7BMdOsgHQpOM5DC25x1ntPelI2xCUjH9NvqcD /2WOfKYOF4wuLBmDyxRPishx3p59Zo48q4v5S2BR6s1UrLf26R10sQhjzrOXYhBh8Wh6 ORJA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1713317734; s=strato-dkim-0003; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=fDLvqjqJKjyDOPBaZE9j7ZwV4xQSKhQzdj8TpSluM3Q=; b=zZsKJKdqvTYFnh4z69FJTpvRtKwbAlUApLVDFwkauk1UFSg1hDWJo93xNPcR3ZxIPz 74ZfItQvD3l8U3WlxvDw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOTjfRkGgmMW2p3jV8cP7Upg8iY" Received: from nimes.localnet by smtp.strato.de (RZmta 50.3.2 AUTH) with ESMTPSA id N8610003H1ZYs8a (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 17 Apr 2024 03:35:34 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org, Collin Funk Subject: Re: Refactoring rewrite_filename functions Date: Wed, 17 Apr 2024 03:35:34 +0200 Message-ID: <26909173.d79VK8dOqj@nimes> In-Reply-To: <4f567b55-2b44-48a3-9cdb-1a8a9570d589@gmail.com> References: <6055935.ntHmXhgcp8@nimes> <4f567b55-2b44-48a3-9cdb-1a8a9570d589@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.216; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Hi Collin, > I'm thinking of making this function accept a single filename instead > of a list Makes sense, as previously discussed. > and then moving it to GLConfig. This does not make sense. GLConfig is meant to hold settings and configuration, nothing more. I see the home of this function more in GLFileSystem.py. Maybe in class GLFileAssistant, maybe in a new class in that same file. > Also, there is a similar section of code to this new function in > main.py line 1313 under "mode == 'copy-file'", but it is missing the > 'tests=lib/' replacement. Would there be a way to simplify that too? > The use of 'tests=lib/' is escaping my mind at the moment... 'tests=lib/' should not occur in the scope of mode == 'copy-file'. But this string is an indicator inside gnulib-tool; users of gnulib-tool should not be allowed to pass it. Bruno