From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Collin Funk <collin.funk1@gmail.com>
Subject: Re: gnulib-tool.py: Remove a redundant function.
Date: Mon, 15 Apr 2024 16:58:45 +0200 [thread overview]
Message-ID: <6735697.07rScijWmr@nimes> (raw)
In-Reply-To: <1b2f9946-96fb-40ea-bd9f-0466bc87456b@gmail.com>
Hi Collin,
> Patch 0002 does this. GLTestDir also has this rewrite_files() function
> so I did the same there. Maybe it is worth making that a helper
> function or using a base class in the future.
>
> Also, the set() and list() calls around zip(...) are important since
> zip() returns an iterator [1]. I've used whichever was most similar to
> the previous code.
Patch 0002 is not applicable because it relies on 0001, which was not good.
Also, the last hunk makes use of yet another Python built-in function 'zip',
where list comprehension [ ... for ... in ... ] is more readable.
> Patch 0003 removes a directories list that was unused. These are
> created in the loop below it as files are written.
In gnulib-tool.sh the directories are created ahead of the loop that
copies the files. Why? Because when we have to create 500 files in the
lib/ directory, it is faster to do 'if not isdir(dirname)' once than
500 times. This is also true in Python.
Bruno
next prev parent reply other threads:[~2024-04-15 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 1:23 gnulib-tool.py: Remove a redundant function Collin Funk
2024-04-15 2:20 ` Collin Funk
2024-04-15 14:58 ` Bruno Haible [this message]
2024-04-15 15:24 ` Collin Funk
2024-04-16 15:09 ` Bruno Haible
2024-04-16 16:23 ` Collin Funk
2024-04-17 1:12 ` Refactoring rewrite_filename functions Collin Funk
2024-04-17 1:35 ` Bruno Haible
2024-04-17 2:08 ` Collin Funk
2024-04-17 14:03 ` Bruno Haible
2024-04-15 11:47 ` gnulib-tool.py: Remove a redundant function Bruno Haible
2024-04-15 14:07 ` Collin Funk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6735697.07rScijWmr@nimes \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=collin.funk1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).