From: Collin Funk <collin.funk1@gmail.com>
To: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Subject: Re: gnulib-tool.py: Remove a redundant function.
Date: Mon, 15 Apr 2024 08:24:35 -0700 [thread overview]
Message-ID: <77cae641-4960-48ea-adf5-6ef28edb658d@gmail.com> (raw)
In-Reply-To: <6735697.07rScijWmr@nimes>
Hi Bruno,
On 4/15/24 7:58 AM, Bruno Haible wrote:
> Patch 0002 is not applicable because it relies on 0001, which was not good.
Yes, I need to rewrite it. But I think the idea of the patch is still
correct. Since it doesn't make sense to accept a list and then only
use it with one element lists.
> Also, the last hunk makes use of yet another Python built-in function 'zip',
> where list comprehension [ ... for ... in ... ] is more readable.
Maybe I am missing something, but I don't think there is a good way to
use a list comprehension here without 'zip'. Since 'zip' is used to
combine these two lists like so:
list1 = [ 1, 2, 3, 4 ]
list2 = [ 5, 6, 7, 8 ]
result = list(zip(list1, list2))
print(result)
[(1, 5), (2, 6), (3, 7), (4, 8)]
This still uses 'zip' but maybe you find it easier to read?
result = [ (a, b) for
a, b in zip(list1, list2) ]
> In gnulib-tool.sh the directories are created ahead of the loop that
> copies the files. Why? Because when we have to create 500 files in the
> lib/ directory, it is faster to do 'if not isdir(dirname)' once than
> 500 times. This is also true in Python.
Ah, yes that makes sense. I'll go fix that now.
Collin
next prev parent reply other threads:[~2024-04-15 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 1:23 gnulib-tool.py: Remove a redundant function Collin Funk
2024-04-15 2:20 ` Collin Funk
2024-04-15 14:58 ` Bruno Haible
2024-04-15 15:24 ` Collin Funk [this message]
2024-04-16 15:09 ` Bruno Haible
2024-04-16 16:23 ` Collin Funk
2024-04-17 1:12 ` Refactoring rewrite_filename functions Collin Funk
2024-04-17 1:35 ` Bruno Haible
2024-04-17 2:08 ` Collin Funk
2024-04-17 14:03 ` Bruno Haible
2024-04-15 11:47 ` gnulib-tool.py: Remove a redundant function Bruno Haible
2024-04-15 14:07 ` Collin Funk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77cae641-4960-48ea-adf5-6ef28edb658d@gmail.com \
--to=collin.funk1@gmail.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).