* tests: Fix ISO C compliance warnings
@ 2020-09-05 14:58 Bruno Haible
0 siblings, 0 replies; only message in thread
From: Bruno Haible @ 2020-09-05 14:58 UTC (permalink / raw)
To: bug-gnulib
When compiling a gnulib testdir with CC="gcc -std=gnu99 -pedantic" I see
these warnings:
test-c-strcasestr.c:63:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-c-strcasestr.c:71:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-memmem.c:93:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-memmem.c:101:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-strcasestr.c:77:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-strcasestr.c:85:26: warning: array initialized from parenthesized string constant [-Wpedantic]
This patch should fix it.
2020-09-05 Bruno Haible <bruno@clisp.org>
Fix "warning: array initialized from parenthesized string constant".
* tests/test-memmem.c (main): Remove parentheses around string constant.
* tests/test-c-strcasestr.c (main): Likewise.
* tests/test-strcasestr.c (main): Likewise.
diff --git a/tests/test-c-strcasestr.c b/tests/test-c-strcasestr.c
index 6ccdd6b..ea8641c 100644
--- a/tests/test-c-strcasestr.c
+++ b/tests/test-c-strcasestr.c
@@ -60,18 +60,18 @@ main ()
/* Check that a long periodic needle does not cause false positives. */
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = c_strcasestr (input, need);
ASSERT (result == NULL);
}
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
- "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
+ "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = c_strcasestr (input, need);
ASSERT (result == input + 115);
diff --git a/tests/test-memmem.c b/tests/test-memmem.c
index 132265f..0368dfd 100644
--- a/tests/test-memmem.c
+++ b/tests/test-memmem.c
@@ -90,18 +90,18 @@ main (int argc, char *argv[])
/* Check that a long periodic needle does not cause false positives. */
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = memmem (input, strlen (input), need, strlen (need));
ASSERT (result == NULL);
}
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
- "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
+ "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = memmem (input, strlen (input), need, strlen (need));
ASSERT (result == input + 115);
diff --git a/tests/test-strcasestr.c b/tests/test-strcasestr.c
index 6100fe3..3a267c6 100644
--- a/tests/test-strcasestr.c
+++ b/tests/test-strcasestr.c
@@ -74,18 +74,18 @@ main ()
/* Check that a long periodic needle does not cause false positives. */
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = strcasestr (input, need);
ASSERT (result == NULL);
}
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
- "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
+ "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = strcasestr (input, need);
ASSERT (result == input + 115);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-05 14:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-05 14:58 tests: Fix ISO C compliance warnings Bruno Haible
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).