From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A9EC11F66E for ; Sat, 5 Sep 2020 14:59:07 +0000 (UTC) Received: from localhost ([::1]:38054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEZek-0001tV-Ej for normalperson@yhbt.net; Sat, 05 Sep 2020 10:59:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEZeg-0001sn-Rq for bug-gnulib@gnu.org; Sat, 05 Sep 2020 10:59:02 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.22]:12653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEZee-0007jT-Kq for bug-gnulib@gnu.org; Sat, 05 Sep 2020 10:59:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1599317937; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=jc+v/x0zu4mD6Hr7/qdIG/kD9Y2chIK1UNTQe+Cde0Q=; b=oin3Pk2Dn8YXotKn6c6d0cjFhvgbdAKrPKYtsm5tHVSkkf5WdrRbSAsyowZmG9QN8r xRRk2g1uI5snewls+4xifGOmD4KQXGstYhmdsCoLtEiTdGMmbHuoumxsICC5NwUwmRzs baPH6eTmJny2BJ1cN40RsHaOSKPsRYi23IPgPXFFWJJwd9veQjp0uWRAR5aJY+cSqdTX /nqBkDTZMHlBrOPs61GwlfvbHvS/Zx9gC5+CjNLS6NWgBAno//sTHoO7EpYEbojkJ5uD sBAEmj6WnX2edaVU4702JpOwBw8KJEMT15sKAsz+FInDTdzXgZGSiWSeNLWgnpcNpdfI nUtw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOHqfyyPs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.10.7 DYNA|AUTH) with ESMTPSA id z05f0fw85EwvBgF (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sat, 5 Sep 2020 16:58:57 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: tests: Fix ISO C compliance warnings Date: Sat, 05 Sep 2020 16:58:56 +0200 Message-ID: <2548530.PZ0UKkzaYM@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-186-generic; KDE/5.18.0; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.22; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/05 10:58:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" When compiling a gnulib testdir with CC="gcc -std=gnu99 -pedantic" I see these warnings: test-c-strcasestr.c:63:26: warning: array initialized from parenthesized string constant [-Wpedantic] test-c-strcasestr.c:71:26: warning: array initialized from parenthesized string constant [-Wpedantic] test-memmem.c:93:26: warning: array initialized from parenthesized string constant [-Wpedantic] test-memmem.c:101:26: warning: array initialized from parenthesized string constant [-Wpedantic] test-strcasestr.c:77:26: warning: array initialized from parenthesized string constant [-Wpedantic] test-strcasestr.c:85:26: warning: array initialized from parenthesized string constant [-Wpedantic] This patch should fix it. 2020-09-05 Bruno Haible Fix "warning: array initialized from parenthesized string constant". * tests/test-memmem.c (main): Remove parentheses around string constant. * tests/test-c-strcasestr.c (main): Likewise. * tests/test-strcasestr.c (main): Likewise. diff --git a/tests/test-c-strcasestr.c b/tests/test-c-strcasestr.c index 6ccdd6b..ea8641c 100644 --- a/tests/test-c-strcasestr.c +++ b/tests/test-c-strcasestr.c @@ -60,18 +60,18 @@ main () /* Check that a long periodic needle does not cause false positives. */ { - const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_A7_20_EF_BF_BD"); + const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_A7_20_EF_BF_BD"; const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"; const char *result = c_strcasestr (input, need); ASSERT (result == NULL); } { - const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20" - "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"); + const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20" + "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"; const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"; const char *result = c_strcasestr (input, need); ASSERT (result == input + 115); diff --git a/tests/test-memmem.c b/tests/test-memmem.c index 132265f..0368dfd 100644 --- a/tests/test-memmem.c +++ b/tests/test-memmem.c @@ -90,18 +90,18 @@ main (int argc, char *argv[]) /* Check that a long periodic needle does not cause false positives. */ { - const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_A7_20_EF_BF_BD"); + const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_A7_20_EF_BF_BD"; const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"; const char *result = memmem (input, strlen (input), need, strlen (need)); ASSERT (result == NULL); } { - const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20" - "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"); + const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20" + "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"; const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"; const char *result = memmem (input, strlen (input), need, strlen (need)); ASSERT (result == input + 115); diff --git a/tests/test-strcasestr.c b/tests/test-strcasestr.c index 6100fe3..3a267c6 100644 --- a/tests/test-strcasestr.c +++ b/tests/test-strcasestr.c @@ -74,18 +74,18 @@ main () /* Check that a long periodic needle does not cause false positives. */ { - const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_A7_20_EF_BF_BD"); + const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_A7_20_EF_BF_BD"; const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"; const char *result = strcasestr (input, need); ASSERT (result == NULL); } { - const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" - "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20" - "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"); + const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD" + "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20" + "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"; const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"; const char *result = strcasestr (input, need); ASSERT (result == input + 115);