From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: tests: Fix ISO C compliance warnings
Date: Sat, 05 Sep 2020 16:58:56 +0200 [thread overview]
Message-ID: <2548530.PZ0UKkzaYM@omega> (raw)
When compiling a gnulib testdir with CC="gcc -std=gnu99 -pedantic" I see
these warnings:
test-c-strcasestr.c:63:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-c-strcasestr.c:71:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-memmem.c:93:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-memmem.c:101:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-strcasestr.c:77:26: warning: array initialized from parenthesized string constant [-Wpedantic]
test-strcasestr.c:85:26: warning: array initialized from parenthesized string constant [-Wpedantic]
This patch should fix it.
2020-09-05 Bruno Haible <bruno@clisp.org>
Fix "warning: array initialized from parenthesized string constant".
* tests/test-memmem.c (main): Remove parentheses around string constant.
* tests/test-c-strcasestr.c (main): Likewise.
* tests/test-strcasestr.c (main): Likewise.
diff --git a/tests/test-c-strcasestr.c b/tests/test-c-strcasestr.c
index 6ccdd6b..ea8641c 100644
--- a/tests/test-c-strcasestr.c
+++ b/tests/test-c-strcasestr.c
@@ -60,18 +60,18 @@ main ()
/* Check that a long periodic needle does not cause false positives. */
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = c_strcasestr (input, need);
ASSERT (result == NULL);
}
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
- "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
+ "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = c_strcasestr (input, need);
ASSERT (result == input + 115);
diff --git a/tests/test-memmem.c b/tests/test-memmem.c
index 132265f..0368dfd 100644
--- a/tests/test-memmem.c
+++ b/tests/test-memmem.c
@@ -90,18 +90,18 @@ main (int argc, char *argv[])
/* Check that a long periodic needle does not cause false positives. */
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = memmem (input, strlen (input), need, strlen (need));
ASSERT (result == NULL);
}
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
- "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
+ "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = memmem (input, strlen (input), need, strlen (need));
ASSERT (result == input + 115);
diff --git a/tests/test-strcasestr.c b/tests/test-strcasestr.c
index 6100fe3..3a267c6 100644
--- a/tests/test-strcasestr.c
+++ b/tests/test-strcasestr.c
@@ -74,18 +74,18 @@ main ()
/* Check that a long periodic needle does not cause false positives. */
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = strcasestr (input, need);
ASSERT (result == NULL);
}
{
- const char input[] = ("F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
- "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
- "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD");
+ const char input[] = "F_BD_CE_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_88_20_EF_BF_BD_EF_BF_BD_EF_BF_BD"
+ "_C3_A7_20_EF_BF_BD_DA_B5_C2_A6_20"
+ "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char need[] = "_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD_EF_BF_BD";
const char *result = strcasestr (input, need);
ASSERT (result == input + 115);
reply other threads:[~2020-09-05 14:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2548530.PZ0UKkzaYM@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).