file-has-acl: fix module description

file-has-acl: fix module description

[Bruno Haible]

The module description has three problems:

1) The condition  [test $gl_need_lib_has_acl]  could give a shell syntax error.
It should be      [test -n "$gl_need_lib_has_acl"].

2) lib/file-has-acl.c needs module acl-permissions unconditionally, to get the
acl_errno_valid function (used both when GETXATTR_WITH_POSIX_ACLS and when
!GETXATTR_WITH_POSIX_ACLS).

3) lib/acl-internal.h and m4/acl.m4 are not part of the public interface of
module 'acl-permissions'. Therefore, the module description needs to list these
files explicitly.


2020-03-22  Bruno Haible  <bruno@clisp.org>

	file-has-acl: Fix module description.
	* modules/file-has-acl (Files): Add lib/acl-internal.h, m4/acl.m4.
	(Depends-on): Depend on acl-permissions unconditionally.

diff --git a/modules/file-has-acl b/modules/file-has-acl
index 7b9b4f5..4857fea 100644
--- a/modules/file-has-acl
+++ b/modules/file-has-acl
@@ -2,10 +2,12 @@ Description:
 Whether a file has an ACL.
 
 Files:
+lib/acl-internal.h
 lib/file-has-acl.c
+m4/acl.m4
 
 Depends-on:
-acl-permissions  [test $gl_need_lib_has_acl]
+acl-permissions
 
 configure.ac:
 gl_FILE_HAS_ACL

Re: file-has-acl: fix module description

[Bruno Haible]

> 1) The condition  [test $gl_need_lib_has_acl]  could give a shell syntax error.
> It should be      [test -n "$gl_need_lib_has_acl"].

Likewise in m4/acl.m4.


2020-03-22  Bruno Haible  <bruno@clisp.org>

	acl-permissions: Improve autoconf macro.
	* m4/acl.m4 (gl_FUNC_ACL): Test the value of gl_need_lib_has_acl
	more reliably.

diff --git a/m4/acl.m4 b/m4/acl.m4
index e459451..a3dcf93 100644
--- a/m4/acl.m4
+++ b/m4/acl.m4
@@ -1,5 +1,5 @@
 # acl.m4 - check for access control list (ACL) primitives
-# serial 23
+# serial 24
 
 # Copyright (C) 2002, 2004-2020 Free Software Foundation, Inc.
 # This file is free software; the Free Software Foundation
@@ -139,7 +139,7 @@ int type = ACL_TYPE_EXTENDED;]])],
       AC_MSG_WARN([AC_PACKAGE_NAME will be built without ACL support.])
     fi
   fi
-  test $gl_need_lib_has_acl && LIB_HAS_ACL=$LIB_ACL
+  test -n "$gl_need_lib_has_acl" && LIB_HAS_ACL=$LIB_ACL
   AC_SUBST([LIB_ACL])
   AC_DEFINE_UNQUOTED([USE_ACL], [$use_acl],
     [Define to nonzero if you want access control list support.])