From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 65B8F1F45D for ; Sun, 22 Mar 2020 12:09:37 +0000 (UTC) Received: from localhost ([::1]:45762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFzQ8-00067p-JB for normalperson@yhbt.net; Sun, 22 Mar 2020 08:09:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45636) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFzQ5-00067W-DB for bug-gnulib@gnu.org; Sun, 22 Mar 2020 08:09:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFzQ4-00041C-Fk for bug-gnulib@gnu.org; Sun, 22 Mar 2020 08:09:33 -0400 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::11]:34318) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFzQ4-00040n-8h for bug-gnulib@gnu.org; Sun, 22 Mar 2020 08:09:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1584878969; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=PwFX2rDjP9ghOfrM4a6CwEbl9IMBOqjv0AYdgjNWp0g=; b=cBMWFpseHSq5H736qEqEtE2lRMo7KmvO90HIoWJfZXJFZLLL4+ebCpup03+qExrBOS E/GkE5YeE/Gw5E3XrRGrCyDiizyS7ZGeuXbJ+ZOpeElaDqnXh/7fSPo85dfJugxamFdf ZDtIwxhjsXosjnGhCjPm0cJIpXkRY9AuvnnWmjPBbUpT7C9l0Xn82pj19irwFbsq6+Zi IjPCYivQP1U46b68Jm3FAZu8eDPam/l81gYsEMXdqRLy5vchkWj6M69kc0NXwrY+299/ QqE5rnj113iEL1T1qxUpOo4ryN+i02ZKvniNnuUZUyx26wOnwA6Hp4yXO3utK9fLtAYE NX3A== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOH6fzxfs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.2.1 DYNA|AUTH) with ESMTPSA id R09594w2MC9SDEs (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sun, 22 Mar 2020 13:09:28 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: file-has-acl: fix module description Date: Sun, 22 Mar 2020 13:09:28 +0100 Message-ID: <1817017.Dq5ENiFNLC@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-174-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <2162890.9dCQd1md00@omega> References: <2162890.9dCQd1md00@omega> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::11 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" > 1) The condition [test $gl_need_lib_has_acl] could give a shell syntax error. > It should be [test -n "$gl_need_lib_has_acl"]. Likewise in m4/acl.m4. 2020-03-22 Bruno Haible acl-permissions: Improve autoconf macro. * m4/acl.m4 (gl_FUNC_ACL): Test the value of gl_need_lib_has_acl more reliably. diff --git a/m4/acl.m4 b/m4/acl.m4 index e459451..a3dcf93 100644 --- a/m4/acl.m4 +++ b/m4/acl.m4 @@ -1,5 +1,5 @@ # acl.m4 - check for access control list (ACL) primitives -# serial 23 +# serial 24 # Copyright (C) 2002, 2004-2020 Free Software Foundation, Inc. # This file is free software; the Free Software Foundation @@ -139,7 +139,7 @@ int type = ACL_TYPE_EXTENDED;]])], AC_MSG_WARN([AC_PACKAGE_NAME will be built without ACL support.]) fi fi - test $gl_need_lib_has_acl && LIB_HAS_ACL=$LIB_ACL + test -n "$gl_need_lib_has_acl" && LIB_HAS_ACL=$LIB_ACL AC_SUBST([LIB_ACL]) AC_DEFINE_UNQUOTED([USE_ACL], [$use_acl], [Define to nonzero if you want access control list support.])