From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 587E91F45D for ; Sun, 22 Mar 2020 12:07:47 +0000 (UTC) Received: from localhost ([::1]:45756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFzOL-0005x5-Ut for normalperson@yhbt.net; Sun, 22 Mar 2020 08:07:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45069) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFzKt-0003TX-Hy for bug-gnulib@gnu.org; Sun, 22 Mar 2020 08:04:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFzKs-0002OD-Du for bug-gnulib@gnu.org; Sun, 22 Mar 2020 08:04:11 -0400 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::8]:12573) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFzKl-0002JR-Jn for bug-gnulib@gnu.org; Sun, 22 Mar 2020 08:04:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1584878633; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=z169KU4leOcbN7swR5Y7Ilz9XelF/mLVXb/dQtE+3hs=; b=AGh/yq+phLu1L5C+9MKV08rIo2RuI/H8Yy/fBgh9wsgiD8duByA4s4dnse6LWNUCZy rw+89ZCy8Q5sqXQBCjMt0Gegj/H0QWg45FRbBqNDurLgiatolBwI8OHMXoxWiYloH7yA Gf3tUHA1e5vAVOwm8o1HBI2LqbUIFPWIbLUFoB8KmVpX3ggFnZDKuXE3boDHbFxTwHOd fjlXWY6oocwCjthA83lz06P57bScqng5nDbe8FvCdLtJLmWZoQMeFAjElfOsH/QUdc53 dpAFLcNROyg5JK66aDFAxqLxEUWVHbybHMwho+cnmTlew7SPs4+MyOjILqsePougTpvX FEvw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOH6fzxfs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.2.1 DYNA|AUTH) with ESMTPSA id R09594w2MC3rDEI (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sun, 22 Mar 2020 13:03:53 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Subject: file-has-acl: fix module description Date: Sun, 22 Mar 2020 13:03:51 +0100 Message-ID: <2162890.9dCQd1md00@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-174-generic; KDE/5.18.0; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::8 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" The module description has three problems: 1) The condition [test $gl_need_lib_has_acl] could give a shell syntax error. It should be [test -n "$gl_need_lib_has_acl"]. 2) lib/file-has-acl.c needs module acl-permissions unconditionally, to get the acl_errno_valid function (used both when GETXATTR_WITH_POSIX_ACLS and when !GETXATTR_WITH_POSIX_ACLS). 3) lib/acl-internal.h and m4/acl.m4 are not part of the public interface of module 'acl-permissions'. Therefore, the module description needs to list these files explicitly. 2020-03-22 Bruno Haible file-has-acl: Fix module description. * modules/file-has-acl (Files): Add lib/acl-internal.h, m4/acl.m4. (Depends-on): Depend on acl-permissions unconditionally. diff --git a/modules/file-has-acl b/modules/file-has-acl index 7b9b4f5..4857fea 100644 --- a/modules/file-has-acl +++ b/modules/file-has-acl @@ -2,10 +2,12 @@ Description: Whether a file has an ACL. Files: +lib/acl-internal.h lib/file-has-acl.c +m4/acl.m4 Depends-on: -acl-permissions [test $gl_need_lib_has_acl] +acl-permissions configure.ac: gl_FILE_HAS_ACL