From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/3] compat: add qsort_s()
Date: Mon, 12 Dec 2016 20:51:14 +0100 [thread overview]
Message-ID: <b8aa28b1-e645-4cea-cc91-96f62fee6118@web.de> (raw)
In-Reply-To: <xmqqy3zz8kmq.fsf@gitster.mtv.corp.google.com>
Am 01.12.2016 um 21:22 schrieb Junio C Hamano:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Eh, wait. BSD and Microsoft have paramters reordered in the
>> callback comparison function. I suspect that would not fly very
>> well.
>
> Hmm. We could do it like this, which may not be too bad.
It's kinda cool to have a bespoke compatibility layer for major
platforms, but the more I think about it the less I can answer why we
would want that. Safety, reliability and performance can't be good
reasons -- if our fallback function lacks in these regards then we have
to improve it in any case.
Text size could be a valid reason, but the full function only adds a bit
more than 2KB to the unstripped git binary.
The flip side is we'd build an ifdef maze that's harder to read and a
lot more difficult to test.
What do we get in return for that additional complexity?
> #if APPLE_QSORT_R
> struct apple_qsort_adapter {
> int (*user_cmp)(const void *, const void *, void *);
> void *user_ctx;
> }
>
> static int apple_qsort_adapter_cmp(void *ctx, const void *a, const void *b)
> {
> struct apple_qsort_adapter *wrapper_ctx = ctx;
> return wrapper_ctx->user_cmp(a, b, wrapper_ctx->user_ctx);
> }
> #endif
>
> int git_qsort_s(void *b, size_t n, size_t s,
> int (*cmp)(const void *, const void *, void *), void *ctx)
> {
> if (!n)
> return 0;
> if (!b || !cmp)
> return -1;
> #if GNU_QSORT_R
> qsort_r(b, n, s, cmp, ctx);
> #elif APPLE_QSORT_R
> {
> struct appple_qsort_adapter a = { cmp, ctx };
> qsort_r(b, n, s, &a, appple_qsort_adapter_cmp);
> }
> #endif
Nit: The fallback for non-GNU, non-Apple systems is missing here, but
the idea is illustrated clearly enough.
> return 0;
> }
>
next prev parent reply other threads:[~2016-12-12 19:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 16:24 [PATCH 0/3] string-list: make string_list_sort() reentrant René Scharfe
2016-12-01 16:26 ` [PATCH 1/3] compat: add qsort_s() René Scharfe
2016-12-01 16:31 ` René Scharfe
2016-12-01 19:35 ` Jeff King
2016-12-01 20:14 ` Junio C Hamano
2016-12-01 20:19 ` Jeff King
2016-12-01 20:25 ` Junio C Hamano
2016-12-01 22:30 ` René Scharfe
2016-12-01 23:37 ` Junio C Hamano
2016-12-01 20:22 ` Junio C Hamano
2016-12-01 20:26 ` Jeff King
2016-12-12 19:51 ` René Scharfe [this message]
2016-12-12 19:57 ` Jeff King
2016-12-21 9:36 ` René Scharfe
2016-12-01 16:28 ` [PATCH 2/3] add QSORT_S René Scharfe
2016-12-01 16:29 ` [PATCH 3/3] string-list: use QSORT_S in string_list_sort() René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8aa28b1-e645-4cea-cc91-96f62fee6118@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).