From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/3] compat: add qsort_s()
Date: Mon, 12 Dec 2016 14:57:03 -0500 [thread overview]
Message-ID: <20161212195703.nmljhwwmrn56gbyd@sigill.intra.peff.net> (raw)
In-Reply-To: <b8aa28b1-e645-4cea-cc91-96f62fee6118@web.de>
On Mon, Dec 12, 2016 at 08:51:14PM +0100, René Scharfe wrote:
> It's kinda cool to have a bespoke compatibility layer for major platforms,
> but the more I think about it the less I can answer why we would want that.
> Safety, reliability and performance can't be good reasons -- if our fallback
> function lacks in these regards then we have to improve it in any case.
There may be cases that we don't want to support because of portability
issues. E.g., if your libc has an assembly-optimized qsort() we wouldn't
want to replicate that.
I dunno. I am not that opposed to just saying "forget libc qsort, we
always use our internal one which is consistent, performant, and safe".
But when I suggested something similar for our regex library, I seem to
recall there were complaints.
-Peff
next prev parent reply other threads:[~2016-12-12 19:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 16:24 [PATCH 0/3] string-list: make string_list_sort() reentrant René Scharfe
2016-12-01 16:26 ` [PATCH 1/3] compat: add qsort_s() René Scharfe
2016-12-01 16:31 ` René Scharfe
2016-12-01 19:35 ` Jeff King
2016-12-01 20:14 ` Junio C Hamano
2016-12-01 20:19 ` Jeff King
2016-12-01 20:25 ` Junio C Hamano
2016-12-01 22:30 ` René Scharfe
2016-12-01 23:37 ` Junio C Hamano
2016-12-01 20:22 ` Junio C Hamano
2016-12-01 20:26 ` Jeff King
2016-12-12 19:51 ` René Scharfe
2016-12-12 19:57 ` Jeff King [this message]
2016-12-21 9:36 ` René Scharfe
2016-12-01 16:28 ` [PATCH 2/3] add QSORT_S René Scharfe
2016-12-01 16:29 ` [PATCH 3/3] string-list: use QSORT_S in string_list_sort() René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212195703.nmljhwwmrn56gbyd@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).