From: "Måns Rullgård" <mans@mansr.com>
To: Jan Stary <hans@stare.cz>
Cc: sox-devel@lists.sourceforge.net
Subject: Re: Build system cleanup
Date: Mon, 24 Aug 2020 15:59:40 +0100 [thread overview]
Message-ID: <yw1ximd8ks2r.fsf@mansr.com> (raw)
In-Reply-To: <20200824144314.GA45261@www.stare.cz> (Jan Stary's message of "Mon, 24 Aug 2020 16:43:14 +0200")
Jan Stary <hans@stare.cz> writes:
> On Aug 24 13:19:36, mans@mansr.com wrote:
>> Jan Stary <hans@stare.cz> writes:
>>
>> >> > cc [...] -o .libs/sox sox.o -L./.libs -lsox -L/usr/local/lib -lpng [...]
>> >> > cc [...] -o .libs/sox sox.o -L/usr/local/lib -L./.libs -lsox -lpng [...]
>> >> >
>> >> > The first works, the second does not.
>> >> > The only difference between the two is the place
>> >> > where the extra -L/usr/local/lib gets added,
>> >> > as described in the previous emails.
>> >
>> > And it seems libtool itself is the one who breaks it.
>> > This is the failing line again:
>> >
>> > /bin/sh ../libtool --tag=CC --mode=link cc -g -O2 -fstack-protector-strong -Wall -Wmissing-prototypes -Wstrict-prototypes -avoid-version -module -L/usr/local/lib -Wl,--as-needed -o sox sox.o libsox.la -lm
>> >
>> > Notice the "-L/usr/local/lib -Wl,--as-needed".
>> > The "-L/usr/local/lib" part comes from the configure arg:
>> >
>> > ./configure CC=cc CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib
>> >
>> > The "-Wl,--as-needed" comes from
>> >
>> > $ grep as-needed configure.ac
>> > AX_APPEND_LINK_FLAGS([-Wl,--as-needed])
>> >
>> > That results in the following line in src/Makefile:
>> >
>> > LDFLAGS = -L/usr/local/lib -Wl,--as-needed
>> >
>> > and that's what is passed in the above command line. Now, libtool
>> > apparently preprocesses the line into something else; in particular,
>> > it reorders the options. The very next command is:
>> >
>> > libtool: link: cc -g -O2 -fstack-protector-strong -Wall -Wmissing-prototypes -Wstrict-prototypes -Wl,--as-needed -o .libs/sox sox.o -L/usr/local/lib -L./.libs -lsox -lpng -lltdl -lao -lgsm -lmad -lmp3lame -ltwolame -lid3tag -lz -lopusfile -lopus -lsndio -lvorbisfile -lwavpack -lcrypto -lsndfile -lFLAC -lvorbisenc -lvorbis -logg -lm -Wl,-rpath,/usr/local/lib
>> >
>> > Notice where the -L/usr/local/lib has been moved.
>> > As described previously, if it comes after -lsox
>> > instead of before it, it links just fine.
>>
>> None of this has changed. The problem is that you have an old libsox in
>> /usr/local/lib, and with that -L flag early in the command, it takes
>> precedence over the just-built libsox, causing the link to fail.
>
> This seems to be the case - together with GNU libtool
> putting that -L/usr/local/lib _before_ the -L./.libs
> which would link with the "new" libsox.
>
> (And, indeed,
> $ nm /usr/local/lib/libsox.so.4.0 | grep lsx_malloc
> $ nm src/.libs/libsox.so.3.0 | grep lsx_malloc
> 00042f60 T lsx_malloc
> which was the actual unresolved symbol, among others).
>
> I can confirm that deleting the previous version of sox
> (installed in /usr/local/ via the OpenBSD sox-14.4.2p5 port)
> makes that problem go away; or, better put, masks the bug
> by removing the condition under which is shows.
Good, we're finally in agreement.
>> This whole issue is unique to OpenBSD.
>
> Having a previous version installed while a new one
> is being built is to be expected, right?
Yes, and it works everywhere I've tested it except OpenBSD.
> Searching for -lsox in the -L path is also perfectly normal.
> As we now know, it is the order of the -L options
> introduced by GNU libtool that breaks it.
>
> Your "clean" VM is a special case in that it does not
> have a previous version installed (as opposed to my screwed up,
> misconfigured machine). When you install the previous sox 14.4.2
> (pkg_add sox), does the
>
> ./configure CC=cc CFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib
> make V=1
>
> build still work?
I assume it will break.
>> On Linux and FreeBSD the link command uses the full filename of libsox,
>> so it isn't searched for in the -L locations.
>
> I didn't get to FreeBSD testing yet, but on NetBSD
> (where the build fails in other interesting ways), it's
>
> libtool: link: gcc -g -O2 -fstack-protector-strong -Wall -Wmissing-prototypes -Wstrict-prototypes -fopenmp -Wl,--as-needed -o .libs/sox sox.o ./.libs/libsox.so -L/usr/pkg/lib -lmagic /usr/pkg/lib/libFLAC.so /usr/pkg/lib/libopusfile.so /usr/pkg/lib/libopus.so /usr/pkg/lib/libvorbisenc.so /usr/pkg/lib/libvorbisfile.so /usr/pkg/lib/libvorbis.so /usr/pkg/lib/libogg.so -lm -fopenmp -Wl,-rpath -Wl,/usr/local/lib -Wl,-rpath -Wl,/usr/pkg/lib
>
> So even some of the external libraries are linked via absolute paths -
> seems to be precisely those detected by pkg-config
> (not sure what the point of pkg-config --libs is then);
> the others (-lm -lmagic) are found in the -L path.
>
> The linking commands are not invented by Linux or FreeBSD or OpenBSD
> - they are what libtool or ./configure (or whatever it is inside the
> auto* maze) put into the actual Makefile(s). If I understand the idea
> of autotools at all, the supposed position of libtool is
>
> "Yo, I know how any given system/linker links;
> so I can issue the right linking commands
> for this system/linker right here, man".
>
> What *is* unique about OpenBSD, then, is that GNU libtool
> does in fact not know how to link here. Does that make sense?
Yes, libtool should put the -L.libs before any other -L flags to avoid
such problems. Why don't you report the bug to them?
--
Måns Rullgård
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel
next prev parent reply other threads:[~2020-08-24 15:00 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 20:40 Build system cleanup Måns Rullgård
2020-08-20 20:40 ` Wolfgang Stoeggl via SoX-devel
2020-08-20 21:22 ` Måns Rullgård
2020-08-20 22:15 ` Wolfgang Stoeggl via SoX-devel
2020-08-21 8:24 ` Jan Stary
2020-08-21 8:16 ` Jan Stary
2020-08-21 8:31 ` Jan Stary
2020-08-21 10:28 ` Måns Rullgård
2020-08-21 12:24 ` Jan Stary
2020-08-21 12:46 ` Måns Rullgård
2020-08-21 8:49 ` Jan Stary
2020-08-21 10:33 ` Måns Rullgård
2020-08-21 12:49 ` Jan Stary
2020-08-21 12:50 ` Jan Stary
2020-08-21 13:32 ` Måns Rullgård
2020-08-21 14:09 ` Jan Stary
2020-08-21 11:15 ` Måns Rullgård
2020-08-21 14:04 ` Jan Stary
2020-08-21 14:47 ` Måns Rullgård
2020-08-21 19:26 ` Wolfgang Stoeggl
2020-08-21 20:20 ` Jan Stary
2020-08-21 15:16 ` Jan Stary
2020-08-21 15:21 ` Jan Stary
2020-08-21 17:08 ` Måns Rullgård
2020-08-21 17:43 ` Jan Stary
2020-08-21 17:52 ` Måns Rullgård
2020-08-21 17:57 ` Jan Stary
2020-08-21 20:17 ` Jan Stary
2020-08-21 20:45 ` Jan Stary
2020-08-21 21:43 ` Måns Rullgård
2020-08-22 8:17 ` Jan Stary
2020-08-22 10:10 ` Måns Rullgård
2020-08-22 15:35 ` Jan Stary
2020-08-22 15:44 ` Jan Stary
2020-08-22 20:54 ` Måns Rullgård
2020-08-23 14:07 ` Jan Stary
2020-08-23 17:13 ` Måns Rullgård
2020-08-23 19:46 ` Jan Stary
2020-08-24 11:04 ` Måns Rullgård
2020-08-24 11:19 ` Jan Stary
2020-08-27 9:38 ` Jan Stary
2020-08-27 10:53 ` Måns Rullgård
2020-08-23 21:55 ` Jan Stary
2020-08-24 6:56 ` Jan Stary
2020-08-27 9:40 ` Jan Stary
2020-08-27 11:08 ` Måns Rullgård
2020-08-27 11:37 ` Jan Stary
2020-08-27 11:53 ` Måns Rullgård
2020-08-27 13:05 ` Jan Stary
2020-08-27 13:31 ` Måns Rullgård
2020-08-27 14:10 ` Jan Stary
2020-08-27 14:38 ` Jan Stary
2020-08-27 15:11 ` Måns Rullgård
2020-08-27 17:41 ` Jan Stary
2020-08-27 18:50 ` Måns Rullgård
2020-08-27 19:18 ` Jan Stary
2020-08-28 4:54 ` Jan Stary
2020-08-28 9:13 ` Måns Rullgård
2020-08-24 12:19 ` Måns Rullgård
2020-08-24 14:43 ` Jan Stary
2020-08-24 14:59 ` Måns Rullgård [this message]
2020-08-27 9:44 ` Jan Stary
2020-08-27 11:08 ` Måns Rullgård
2020-08-24 17:22 ` Måns Rullgård
2020-08-22 15:43 ` Jan Stary
2020-08-22 15:48 ` Jan Stary
2020-08-24 12:18 ` Jan Stary
2020-08-24 12:27 ` Måns Rullgård
2020-08-24 13:16 ` Jan Stary
2020-08-24 14:15 ` Måns Rullgård
2020-08-27 9:52 ` Jan Stary
2020-08-27 11:10 ` Måns Rullgård
-- strict thread matches above, loose matches on Subject: below --
2020-08-21 8:52 Jan Stary
2020-08-21 10:36 ` Måns Rullgård
2020-08-21 12:22 ` Jan Stary
2020-08-21 12:27 ` Måns Rullgård
2020-08-27 9:21 Jan Stary
2020-08-27 10:54 ` Jan Stary
2020-08-27 11:52 ` Måns Rullgård
2020-08-27 12:40 ` Jan Stary
2020-08-27 12:44 ` Jan Stary
2020-08-27 12:45 ` Måns Rullgård
2020-08-27 17:45 ` Jan Stary
2020-08-27 18:59 ` Måns Rullgård
2020-08-27 19:51 ` Jan Stary
2020-08-27 20:01 ` Jan Stary
2020-08-28 9:21 ` Måns Rullgård
2020-08-28 9:35 ` Jan Stary
2020-08-28 9:43 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.sourceforge.net/lists/listinfo/sox-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1ximd8ks2r.fsf@mansr.com \
--to=sox-devel@lists.sourceforge.net \
--cc=hans@stare.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/sox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).