From: "Wolfgang Stoeggl" <wolfgang.stoeggl@aon.at>
To: <sox-devel@lists.sourceforge.net>
Subject: Re: Build system cleanup
Date: Fri, 21 Aug 2020 21:26:04 +0200 [thread overview]
Message-ID: <009901d677f0$ea880f10$bf982d30$@aon.at> (raw)
In-Reply-To: <20200821140458.GA48586@www.stare.cz>
> Von: Jan Stary <hans@stare.cz>
> Gesendet: Freitag, 21. August 2020 16:05
> An: Måns Rullgård <mans@mansr.com>
> Cc: sox-devel@lists.sourceforge.net
> Betreff: Re: [SoX-devel] Build system cleanup
>
...
> > > checking for lpc10.h... no
> > >
> > > So why does it try to build lpc support later,
> > > #including the lpc10.h that was not found?
> >
> > I made a mistake.
>
> Wolfgang reported it fixed but I don't see any other commit on the branch;
> am I missign something obvious?
>
Hi Jan,
The fix is part of the following commit:
https://sourceforge.net/p/sox/code/ci/66af4a355ac51bbd8b50ba8f81419feb7f1f2f
7d/
There was no separate commit. I guess, it was amended and force-pushed.
The relevant diff of the fix looks like this:
--- a/configure.ac 2020-08-20 22:11:24.000000000 +0200
+++ b/configure.ac 2020-08-20 23:48:46.594315800 +0200
@@ -110,7 +110,7 @@
# Check for liblpc10
SOX_CHECK_LIB([LIBLPC10], [lpc10.h], [lpc10], [create_lpc10_encoder_state],
[LPC10_LIBS="$LIBLPC10_LIBS"],
- [LPC10_LIBS=../lpc10/liblpc10.la; LPC10_CFLAGS="-I$srcdir/lpc10"])
+ [LPC10_LIBS=../lpc10/liblpc10.la;
LPC10_CFLAGS='-I${top_srcdir}/lpc10'])
AM_CONDITIONAL([HAVE_LIBLPC10], [test $HAVE_LIBLPC10 = yes])
SOX_ENABLE([formats], [Default setting for optional formats],
Best regards
Wolfgang
_______________________________________________
SoX-devel mailing list
SoX-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sox-devel
next prev parent reply other threads:[~2020-08-21 19:46 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 20:40 Build system cleanup Måns Rullgård
2020-08-20 20:40 ` Wolfgang Stoeggl via SoX-devel
2020-08-20 21:22 ` Måns Rullgård
2020-08-20 22:15 ` Wolfgang Stoeggl via SoX-devel
2020-08-21 8:24 ` Jan Stary
2020-08-21 8:16 ` Jan Stary
2020-08-21 8:31 ` Jan Stary
2020-08-21 10:28 ` Måns Rullgård
2020-08-21 12:24 ` Jan Stary
2020-08-21 12:46 ` Måns Rullgård
2020-08-21 8:49 ` Jan Stary
2020-08-21 10:33 ` Måns Rullgård
2020-08-21 12:49 ` Jan Stary
2020-08-21 12:50 ` Jan Stary
2020-08-21 13:32 ` Måns Rullgård
2020-08-21 14:09 ` Jan Stary
2020-08-21 11:15 ` Måns Rullgård
2020-08-21 14:04 ` Jan Stary
2020-08-21 14:47 ` Måns Rullgård
2020-08-21 19:26 ` Wolfgang Stoeggl [this message]
2020-08-21 20:20 ` Jan Stary
2020-08-21 15:16 ` Jan Stary
2020-08-21 15:21 ` Jan Stary
2020-08-21 17:08 ` Måns Rullgård
2020-08-21 17:43 ` Jan Stary
2020-08-21 17:52 ` Måns Rullgård
2020-08-21 17:57 ` Jan Stary
2020-08-21 20:17 ` Jan Stary
2020-08-21 20:45 ` Jan Stary
2020-08-21 21:43 ` Måns Rullgård
2020-08-22 8:17 ` Jan Stary
2020-08-22 10:10 ` Måns Rullgård
2020-08-22 15:35 ` Jan Stary
2020-08-22 15:44 ` Jan Stary
2020-08-22 20:54 ` Måns Rullgård
2020-08-23 14:07 ` Jan Stary
2020-08-23 17:13 ` Måns Rullgård
2020-08-23 19:46 ` Jan Stary
2020-08-24 11:04 ` Måns Rullgård
2020-08-24 11:19 ` Jan Stary
2020-08-27 9:38 ` Jan Stary
2020-08-27 10:53 ` Måns Rullgård
2020-08-23 21:55 ` Jan Stary
2020-08-24 6:56 ` Jan Stary
2020-08-27 9:40 ` Jan Stary
2020-08-27 11:08 ` Måns Rullgård
2020-08-27 11:37 ` Jan Stary
2020-08-27 11:53 ` Måns Rullgård
2020-08-27 13:05 ` Jan Stary
2020-08-27 13:31 ` Måns Rullgård
2020-08-27 14:10 ` Jan Stary
2020-08-27 14:38 ` Jan Stary
2020-08-27 15:11 ` Måns Rullgård
2020-08-27 17:41 ` Jan Stary
2020-08-27 18:50 ` Måns Rullgård
2020-08-27 19:18 ` Jan Stary
2020-08-28 4:54 ` Jan Stary
2020-08-28 9:13 ` Måns Rullgård
2020-08-24 12:19 ` Måns Rullgård
2020-08-24 14:43 ` Jan Stary
2020-08-24 14:59 ` Måns Rullgård
2020-08-27 9:44 ` Jan Stary
2020-08-27 11:08 ` Måns Rullgård
2020-08-24 17:22 ` Måns Rullgård
2020-08-22 15:43 ` Jan Stary
2020-08-22 15:48 ` Jan Stary
2020-08-24 12:18 ` Jan Stary
2020-08-24 12:27 ` Måns Rullgård
2020-08-24 13:16 ` Jan Stary
2020-08-24 14:15 ` Måns Rullgård
2020-08-27 9:52 ` Jan Stary
2020-08-27 11:10 ` Måns Rullgård
-- strict thread matches above, loose matches on Subject: below --
2020-08-21 8:52 Jan Stary
2020-08-21 10:36 ` Måns Rullgård
2020-08-21 12:22 ` Jan Stary
2020-08-21 12:27 ` Måns Rullgård
2020-08-27 9:21 Jan Stary
2020-08-27 10:54 ` Jan Stary
2020-08-27 11:52 ` Måns Rullgård
2020-08-27 12:40 ` Jan Stary
2020-08-27 12:44 ` Jan Stary
2020-08-27 12:45 ` Måns Rullgård
2020-08-27 17:45 ` Jan Stary
2020-08-27 18:59 ` Måns Rullgård
2020-08-27 19:51 ` Jan Stary
2020-08-27 20:01 ` Jan Stary
2020-08-28 9:21 ` Måns Rullgård
2020-08-28 9:35 ` Jan Stary
2020-08-28 9:43 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.sourceforge.net/lists/listinfo/sox-devel
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009901d677f0$ea880f10$bf982d30$@aon.at' \
--to=sox-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/sox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).