[ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70

[ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70

[byroot (Jean Boussier)]

Issue #18938 has been reported by byroot (Jean Boussier).

----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938

* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/pull/6166 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1

Ref: https://github.com/ruby/ruby/pull/6166



-- 
https://bugs.ruby-lang.org/

[ruby-core:109867] [Ruby master Bug#18938] Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19

[nagachika (Tomoyuki Chikanaga)]

Issue #18938 has been updated by nagachika (Tomoyuki Chikanaga).


I tried to backport cf7d07570f50ef9c16007019afcff11ba6500d70 and c6aa65430fbb94651f4d15e2a976f59b5475ca19 into ruby_3_1 branch, but the test `test_utf8_method_names` failed. Maybe some more changesets are needed. I will investigate it further.

```  1) Error:
TestObjSpace#test_utf8_method_names:
JSON::ParserError: 859: unexpected token at '{"address":"0x10465a248", "type":"STRING", "class":"0x101cf2450", "embedded":true, "bytesize":2, "value":"12", "encoding":"UTF-8", "file":"/Users/nagachika/opt/ruby-3.1/src/ruby_3_1/test/objspace/test_objspace.rb", "line":649, "method":"utf8_\u00ff'
    /Users/nagachika/opt/ruby-3.1/src/build/.ext/common/json/common.rb:216:in `parse'
    /Users/nagachika/opt/ruby-3.1/src/build/.ext/common/json/common.rb:216:in `parse'
    /Users/nagachika/opt/ruby-3.1/src/ruby_3_1/test/objspace/test_objspace.rb:642:in `test_utf8_method_names'
```

----------------------------------------
Bug #18938: Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19
https://bugs.ruby-lang.org/issues/18938#change-99107

* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/c6aa65430fbb94651f4d15e2a976f59b5475ca19 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1

Ref: https://github.com/ruby/ruby/pull/6166

cc @nobu



-- 
https://bugs.ruby-lang.org/

[ruby-core:109888] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70

[byroot (Jean Boussier)]

Issue #18938 has been updated by byroot (Jean Boussier).

Subject changed from Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19 to Backport cf7d07570f50ef9c16007019afcff11ba6500d70
Description updated

@nagachika it's my fault. For backporting purpose `cf7d07570f50ef9c16007019afcff11ba6500d70` alone should be backported and `c6aa65430fbb94651f4d15e2a976f59b5475ca19` should be ignored.

----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99130

* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1

Ref: https://github.com/ruby/ruby/pull/6166

cc @nobu



-- 
https://bugs.ruby-lang.org/

[ruby-core:110062] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70

[nagachika (Tomoyuki Chikanaga)]

Issue #18938 has been updated by nagachika (Tomoyuki Chikanaga).


I have got the same error with only backporting cf7d07570f50ef9c16007019afcff11ba6500d70.

----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99313

* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1

Ref: https://github.com/ruby/ruby/pull/6166

cc @nobu



-- 
https://bugs.ruby-lang.org/

[ruby-core:110066] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70

[byroot (Jean Boussier)]

Issue #18938 has been updated by byroot (Jean Boussier).


@nagachika on 3.0, 3.1 or both?

----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99317

* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1

Ref: https://github.com/ruby/ruby/pull/6166

cc @nobu



-- 
https://bugs.ruby-lang.org/

[ruby-core:110067] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70

[byroot (Jean Boussier)]

Issue #18938 has been updated by byroot (Jean Boussier).


I don't understand, it works fine on my machine. I made two backport PRs, maybe it doesn't work on some system and CI will catch it?

  - 3.1: https://github.com/ruby/ruby/pull/6431
  - 3.0: https://github.com/ruby/ruby/pull/6432



----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99318

* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1

Ref: https://github.com/ruby/ruby/pull/6166

cc @nobu



-- 
https://bugs.ruby-lang.org/

[ruby-core:110069] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70

[nagachika (Tomoyuki Chikanaga)]

Issue #18938 has been updated by nagachika (Tomoyuki Chikanaga).


I tested on ruby_3_1 branch.
I'm afraid I failed to rebuild extensions before run make test-all on my environments.


----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99320

* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1

Ref: https://github.com/ruby/ruby/pull/6166

cc @nobu



-- 
https://bugs.ruby-lang.org/

[ruby-core:110070] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70

[nagachika (Tomoyuki Chikanaga)]

Issue #18938 has been updated by nagachika (Tomoyuki Chikanaga).

Backport changed from 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: DONTNEED, 3.0: REQUIRED, 3.1: DONE

ruby_3_1 e46532feafadef252682794c941180df72483c19 merged revision(s) cf7d07570f50ef9c16007019afcff11ba6500d70.

----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99321

* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: DONE
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1

Ref: https://github.com/ruby/ruby/pull/6166

cc @nobu



-- 
https://bugs.ruby-lang.org/