* [ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70
@ 2022-07-25 7:58 byroot (Jean Boussier)
2022-09-10 7:12 ` [ruby-core:109867] [Ruby master Bug#18938] Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19 nagachika (Tomoyuki Chikanaga)
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: byroot (Jean Boussier) @ 2022-07-25 7:58 UTC (permalink / raw)
To: ruby-core
Issue #18938 has been reported by byroot (Jean Boussier).
----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938
* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/pull/6166 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1
Ref: https://github.com/ruby/ruby/pull/6166
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
* [ruby-core:109867] [Ruby master Bug#18938] Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19
2022-07-25 7:58 [ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
@ 2022-09-10 7:12 ` nagachika (Tomoyuki Chikanaga)
2022-09-12 7:24 ` [ruby-core:109888] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: nagachika (Tomoyuki Chikanaga) @ 2022-09-10 7:12 UTC (permalink / raw)
To: ruby-core
Issue #18938 has been updated by nagachika (Tomoyuki Chikanaga).
I tried to backport cf7d07570f50ef9c16007019afcff11ba6500d70 and c6aa65430fbb94651f4d15e2a976f59b5475ca19 into ruby_3_1 branch, but the test `test_utf8_method_names` failed. Maybe some more changesets are needed. I will investigate it further.
``` 1) Error:
TestObjSpace#test_utf8_method_names:
JSON::ParserError: 859: unexpected token at '{"address":"0x10465a248", "type":"STRING", "class":"0x101cf2450", "embedded":true, "bytesize":2, "value":"12", "encoding":"UTF-8", "file":"/Users/nagachika/opt/ruby-3.1/src/ruby_3_1/test/objspace/test_objspace.rb", "line":649, "method":"utf8_\u00ff'
/Users/nagachika/opt/ruby-3.1/src/build/.ext/common/json/common.rb:216:in `parse'
/Users/nagachika/opt/ruby-3.1/src/build/.ext/common/json/common.rb:216:in `parse'
/Users/nagachika/opt/ruby-3.1/src/ruby_3_1/test/objspace/test_objspace.rb:642:in `test_utf8_method_names'
```
----------------------------------------
Bug #18938: Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19
https://bugs.ruby-lang.org/issues/18938#change-99107
* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/c6aa65430fbb94651f4d15e2a976f59b5475ca19 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1
Ref: https://github.com/ruby/ruby/pull/6166
cc @nobu
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
* [ruby-core:109888] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70
2022-07-25 7:58 [ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
2022-09-10 7:12 ` [ruby-core:109867] [Ruby master Bug#18938] Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19 nagachika (Tomoyuki Chikanaga)
@ 2022-09-12 7:24 ` byroot (Jean Boussier)
2022-09-25 6:14 ` [ruby-core:110062] " nagachika (Tomoyuki Chikanaga)
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: byroot (Jean Boussier) @ 2022-09-12 7:24 UTC (permalink / raw)
To: ruby-core
Issue #18938 has been updated by byroot (Jean Boussier).
Subject changed from Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19 to Backport cf7d07570f50ef9c16007019afcff11ba6500d70
Description updated
@nagachika it's my fault. For backporting purpose `cf7d07570f50ef9c16007019afcff11ba6500d70` alone should be backported and `c6aa65430fbb94651f4d15e2a976f59b5475ca19` should be ignored.
----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99130
* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1
Ref: https://github.com/ruby/ruby/pull/6166
cc @nobu
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
* [ruby-core:110062] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70
2022-07-25 7:58 [ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
2022-09-10 7:12 ` [ruby-core:109867] [Ruby master Bug#18938] Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19 nagachika (Tomoyuki Chikanaga)
2022-09-12 7:24 ` [ruby-core:109888] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
@ 2022-09-25 6:14 ` nagachika (Tomoyuki Chikanaga)
2022-09-25 9:27 ` [ruby-core:110066] " byroot (Jean Boussier)
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: nagachika (Tomoyuki Chikanaga) @ 2022-09-25 6:14 UTC (permalink / raw)
To: ruby-core
Issue #18938 has been updated by nagachika (Tomoyuki Chikanaga).
I have got the same error with only backporting cf7d07570f50ef9c16007019afcff11ba6500d70.
----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99313
* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1
Ref: https://github.com/ruby/ruby/pull/6166
cc @nobu
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
* [ruby-core:110066] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70
2022-07-25 7:58 [ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
` (2 preceding siblings ...)
2022-09-25 6:14 ` [ruby-core:110062] " nagachika (Tomoyuki Chikanaga)
@ 2022-09-25 9:27 ` byroot (Jean Boussier)
2022-09-25 9:38 ` [ruby-core:110067] " byroot (Jean Boussier)
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: byroot (Jean Boussier) @ 2022-09-25 9:27 UTC (permalink / raw)
To: ruby-core
Issue #18938 has been updated by byroot (Jean Boussier).
@nagachika on 3.0, 3.1 or both?
----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99317
* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1
Ref: https://github.com/ruby/ruby/pull/6166
cc @nobu
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
* [ruby-core:110067] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70
2022-07-25 7:58 [ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
` (3 preceding siblings ...)
2022-09-25 9:27 ` [ruby-core:110066] " byroot (Jean Boussier)
@ 2022-09-25 9:38 ` byroot (Jean Boussier)
2022-09-25 12:21 ` [ruby-core:110069] " nagachika (Tomoyuki Chikanaga)
2022-09-25 12:25 ` [ruby-core:110070] " nagachika (Tomoyuki Chikanaga)
6 siblings, 0 replies; 8+ messages in thread
From: byroot (Jean Boussier) @ 2022-09-25 9:38 UTC (permalink / raw)
To: ruby-core
Issue #18938 has been updated by byroot (Jean Boussier).
I don't understand, it works fine on my machine. I made two backport PRs, maybe it doesn't work on some system and CI will catch it?
- 3.1: https://github.com/ruby/ruby/pull/6431
- 3.0: https://github.com/ruby/ruby/pull/6432
----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99318
* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1
Ref: https://github.com/ruby/ruby/pull/6166
cc @nobu
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
* [ruby-core:110069] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70
2022-07-25 7:58 [ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
` (4 preceding siblings ...)
2022-09-25 9:38 ` [ruby-core:110067] " byroot (Jean Boussier)
@ 2022-09-25 12:21 ` nagachika (Tomoyuki Chikanaga)
2022-09-25 12:25 ` [ruby-core:110070] " nagachika (Tomoyuki Chikanaga)
6 siblings, 0 replies; 8+ messages in thread
From: nagachika (Tomoyuki Chikanaga) @ 2022-09-25 12:21 UTC (permalink / raw)
To: ruby-core
Issue #18938 has been updated by nagachika (Tomoyuki Chikanaga).
I tested on ruby_3_1 branch.
I'm afraid I failed to rebuild extensions before run make test-all on my environments.
----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99320
* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1
Ref: https://github.com/ruby/ruby/pull/6166
cc @nobu
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
* [ruby-core:110070] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70
2022-07-25 7:58 [ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
` (5 preceding siblings ...)
2022-09-25 12:21 ` [ruby-core:110069] " nagachika (Tomoyuki Chikanaga)
@ 2022-09-25 12:25 ` nagachika (Tomoyuki Chikanaga)
6 siblings, 0 replies; 8+ messages in thread
From: nagachika (Tomoyuki Chikanaga) @ 2022-09-25 12:25 UTC (permalink / raw)
To: ruby-core
Issue #18938 has been updated by nagachika (Tomoyuki Chikanaga).
Backport changed from 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: DONTNEED, 3.0: REQUIRED, 3.1: DONE
ruby_3_1 e46532feafadef252682794c941180df72483c19 merged revision(s) cf7d07570f50ef9c16007019afcff11ba6500d70.
----------------------------------------
Bug #18938: Backport cf7d07570f50ef9c16007019afcff11ba6500d70
https://bugs.ruby-lang.org/issues/18938#change-99321
* Author: byroot (Jean Boussier)
* Status: Closed
* Priority: Normal
* Backport: 2.7: DONTNEED, 3.0: REQUIRED, 3.1: DONE
----------------------------------------
Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in `ObjectSpace.dump` for Ruby 3.0 and Ruby 3.1
Ref: https://github.com/ruby/ruby/pull/6166
cc @nobu
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-25 12:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-25 7:58 [ruby-core:109314] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
2022-09-10 7:12 ` [ruby-core:109867] [Ruby master Bug#18938] Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19 nagachika (Tomoyuki Chikanaga)
2022-09-12 7:24 ` [ruby-core:109888] [Ruby master Bug#18938] Backport cf7d07570f50ef9c16007019afcff11ba6500d70 byroot (Jean Boussier)
2022-09-25 6:14 ` [ruby-core:110062] " nagachika (Tomoyuki Chikanaga)
2022-09-25 9:27 ` [ruby-core:110066] " byroot (Jean Boussier)
2022-09-25 9:38 ` [ruby-core:110067] " byroot (Jean Boussier)
2022-09-25 12:21 ` [ruby-core:110069] " nagachika (Tomoyuki Chikanaga)
2022-09-25 12:25 ` [ruby-core:110070] " nagachika (Tomoyuki Chikanaga)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).