* [ruby-core:101695] [Ruby master Bug#17468] Deprecate RUBY_DEVEL
@ 2020-12-25 9:32 naruse
2021-10-19 21:29 ` [ruby-core:105683] [Ruby master Feature#17468] " jeremyevans0 (Jeremy Evans)
2021-12-25 7:45 ` [ruby-core:106819] " mame (Yusuke Endoh)
0 siblings, 2 replies; 3+ messages in thread
From: naruse @ 2020-12-25 9:32 UTC (permalink / raw)
To: ruby-core
Issue #17468 has been reported by naruse (Yui NARUSE).
----------------------------------------
Bug #17468: Deprecate RUBY_DEVEL
https://bugs.ruby-lang.org/issues/17468
* Author: naruse (Yui NARUSE)
* Status: Open
* Priority: Normal
* Target version: 3.1
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Some configuration of Ruby use RUBY_DEVEL, which depends PATCH_LEVEL.
But depending PATCH_LEVEL causes issues which will become revealed on the final release.
Though we release some previews and RCs, they don't contributes the quality around RUBY_DEVEL.
Therefore to ensure CI tests the quality of the final release, we need to deprecate RUBY_DEVEL.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:105683] [Ruby master Feature#17468] Deprecate RUBY_DEVEL
2020-12-25 9:32 [ruby-core:101695] [Ruby master Bug#17468] Deprecate RUBY_DEVEL naruse
@ 2021-10-19 21:29 ` jeremyevans0 (Jeremy Evans)
2021-12-25 7:45 ` [ruby-core:106819] " mame (Yusuke Endoh)
1 sibling, 0 replies; 3+ messages in thread
From: jeremyevans0 (Jeremy Evans) @ 2021-10-19 21:29 UTC (permalink / raw)
To: ruby-core
Issue #17468 has been updated by jeremyevans0 (Jeremy Evans).
I looked into this. If we removed `RUBY_DEVEL`, we would make it so `ruby_debug_log` was never defined, since it is only defined if `RUBY_DEVEL` is defined. Basically, removing `RUBY_DEVEL` is equivalent to removing the removing the entire debug logging feature.
I think a safer and less invasive change is to make `RUBY_DEVEL` not depend on `PATCH_LEVEL`. By doing so, Ruby developers that want to use debug logging can still manually use `RUBY_DEVEL=yes` when configuring, but it will never be enabled automatically. I submitted a pull request for this: https://github.com/ruby/ruby/pull/4993. One change it makes is to set `USE_RUBY_DEBUG_LOG` to 1 instead of 0 if `RUBY_DEVEL` is defined and `USE_RUBY_DEBUG_LOG` isn't. Since `RUBY_DEVEL` is no longer enabled automatically, the main reason to enable it would be to support debug logging, in which case I think `1` is a better default.
----------------------------------------
Feature #17468: Deprecate RUBY_DEVEL
https://bugs.ruby-lang.org/issues/17468#change-94183
* Author: naruse (Yui NARUSE)
* Status: Open
* Priority: Normal
* Target version: 3.1
----------------------------------------
Some configuration of Ruby use RUBY_DEVEL, which depends PATCH_LEVEL.
But depending PATCH_LEVEL causes issues which will become revealed on the final release.
Though we release some previews and RCs, they don't contributes the quality around RUBY_DEVEL.
Therefore to ensure CI tests the quality of the final release, we need to deprecate RUBY_DEVEL.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ruby-core:106819] [Ruby master Feature#17468] Deprecate RUBY_DEVEL
2020-12-25 9:32 [ruby-core:101695] [Ruby master Bug#17468] Deprecate RUBY_DEVEL naruse
2021-10-19 21:29 ` [ruby-core:105683] [Ruby master Feature#17468] " jeremyevans0 (Jeremy Evans)
@ 2021-12-25 7:45 ` mame (Yusuke Endoh)
1 sibling, 0 replies; 3+ messages in thread
From: mame (Yusuke Endoh) @ 2021-12-25 7:45 UTC (permalink / raw)
To: ruby-core
Issue #17468 has been updated by mame (Yusuke Endoh).
When packaging a new tarball, we faced this issue again. Building a tarball produces so many warnings:
```
./vm_debug.h:34:5: warning: "RUBY_DEVEL" is not defined, evaluates to 0 [-Wundef]
34 | #if RUBY_DEVEL
| ^~~~~~~~~~
./vm_debug.h:100:5: warning: "USE_RUBY_DEBUG_LOG" is not defined, evaluates to 0 [-Wundef]
100 | #if USE_RUBY_DEBUG_LOG
| ^~~~~~~~~~~~~~~~~~
In file included from ./vm.c:40:
./vm_sync.h:7:5: warning: "USE_RUBY_DEBUG_LOG" is not defined, evaluates to 0 [-Wundef]
7 | #if USE_RUBY_DEBUG_LOG
| ^~~~~~~~~~~~~~~~~~
```
----------------------------------------
Feature #17468: Deprecate RUBY_DEVEL
https://bugs.ruby-lang.org/issues/17468#change-95630
* Author: naruse (Yui NARUSE)
* Status: Open
* Priority: Normal
* Target version: 3.1
----------------------------------------
Some configuration of Ruby use RUBY_DEVEL, which depends PATCH_LEVEL.
But depending PATCH_LEVEL causes issues which will become revealed on the final release.
Though we release some previews and RCs, they don't contributes the quality around RUBY_DEVEL.
Therefore to ensure CI tests the quality of the final release, we need to deprecate RUBY_DEVEL.
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-25 7:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-25 9:32 [ruby-core:101695] [Ruby master Bug#17468] Deprecate RUBY_DEVEL naruse
2021-10-19 21:29 ` [ruby-core:105683] [Ruby master Feature#17468] " jeremyevans0 (Jeremy Evans)
2021-12-25 7:45 ` [ruby-core:106819] " mame (Yusuke Endoh)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).