ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "jeremyevans0 (Jeremy Evans)" <noreply@ruby-lang.org>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:105683] [Ruby master Feature#17468] Deprecate RUBY_DEVEL
Date: Tue, 19 Oct 2021 21:29:01 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-94183.20211019212901.5@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17468.20201225093250.5@ruby-lang.org

Issue #17468 has been updated by jeremyevans0 (Jeremy Evans).


I looked into this.  If we removed `RUBY_DEVEL`, we would make it so `ruby_debug_log` was never defined, since it is only defined if `RUBY_DEVEL` is defined.  Basically, removing `RUBY_DEVEL` is equivalent to removing the removing the entire debug logging feature.

I think a safer and less invasive change is to make `RUBY_DEVEL` not depend on `PATCH_LEVEL`.  By doing so, Ruby developers that want to use debug logging can still manually use `RUBY_DEVEL=yes` when configuring, but it will never be enabled automatically. I submitted a pull request for this: https://github.com/ruby/ruby/pull/4993.  One change it makes is to set `USE_RUBY_DEBUG_LOG` to 1 instead of 0 if `RUBY_DEVEL` is defined and `USE_RUBY_DEBUG_LOG` isn't.  Since `RUBY_DEVEL` is no longer enabled automatically, the main reason to enable it would be to support debug logging, in which case I think `1` is a better default.

----------------------------------------
Feature #17468: Deprecate RUBY_DEVEL
https://bugs.ruby-lang.org/issues/17468#change-94183

* Author: naruse (Yui NARUSE)
* Status: Open
* Priority: Normal
* Target version: 3.1
----------------------------------------
Some configuration of Ruby use RUBY_DEVEL, which depends PATCH_LEVEL.
But depending PATCH_LEVEL causes issues which will become revealed on the final release.
Though we release some previews and RCs, they don't contributes the quality around RUBY_DEVEL.

Therefore to ensure CI tests the quality of the final release, we need to deprecate RUBY_DEVEL.



-- 
https://bugs.ruby-lang.org/

  reply	other threads:[~2021-10-19 21:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-25  9:32 [ruby-core:101695] [Ruby master Bug#17468] Deprecate RUBY_DEVEL naruse
2021-10-19 21:29 ` jeremyevans0 (Jeremy Evans) [this message]
2021-12-25  7:45 ` [ruby-core:106819] [Ruby master Feature#17468] " mame (Yusuke Endoh)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-94183.20211019212901.5@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).