ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:105416] [Ruby master Misc#18191] All internal filenames should be in UTF-8
@ 2021-09-25  8:23 NuriYuri (Youri Nouri)
  2021-09-29  1:28 ` [ruby-core:105480] [Ruby master Bug#18191] All loaded feature filenames should be in the file system encoding nobu (Nobuyoshi Nakada)
  2021-10-09  6:37 ` [ruby-core:105612] " nagachika (Tomoyuki Chikanaga)
  0 siblings, 2 replies; 3+ messages in thread
From: NuriYuri (Youri Nouri) @ 2021-09-25  8:23 UTC (permalink / raw)
  To: ruby-core

Issue #18191 has been reported by NuriYuri (Youri Nouri).

----------------------------------------
Misc #18191: All internal filenames should be in UTF-8
https://bugs.ruby-lang.org/issues/18191

* Author: NuriYuri (Youri Nouri)
* Status: Open
* Priority: Normal
----------------------------------------
I don't know if that has already been fixed but it seems that few internal variables ($LOADED_FEATURES) are still containing paths announced as BINARY instead of UTF-8. (While their content is actually UTF-8 Data).

Here's some evidence of the issue:
https://www.zupimages.net/up/21/38/g8a0.png
```
p $LOADED_FEATURES[5]
=> "D:/nuriy/Work/pok\xC3\xA9monsdk/lib/ruby/3.0.0/i386-mingw32/enc/encdb.so"
p $LOADED_FEATURES[5].encoding
=> #<Encoding:ASCII-8BIT>
```

Here's the fix I made to prevent the issue: https://gitlab.com/pokemonsdk/pokemonsdk/-/commit/c9b27ecad1c4b5016e2ef56a3f1df25e74395ce4
I believe that it can be fixed by setting the right encoding in the generated string object when $LOADED_FEATURES is filled.

ruby -v: `ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [i386-mingw32]`
Content of psdk.bat: `ruby.exe --disable=gems,rubyopt,did_you_mean Game.rb %*`



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:105480] [Ruby master Bug#18191] All loaded feature filenames should be in the file system encoding
  2021-09-25  8:23 [ruby-core:105416] [Ruby master Misc#18191] All internal filenames should be in UTF-8 NuriYuri (Youri Nouri)
@ 2021-09-29  1:28 ` nobu (Nobuyoshi Nakada)
  2021-10-09  6:37 ` [ruby-core:105612] " nagachika (Tomoyuki Chikanaga)
  1 sibling, 0 replies; 3+ messages in thread
From: nobu (Nobuyoshi Nakada) @ 2021-09-29  1:28 UTC (permalink / raw)
  To: ruby-core

Issue #18191 has been updated by nobu (Nobuyoshi Nakada).

Subject changed from All internal filenames should be in UTF-8 to All loaded feature filenames should be in the file system encoding

* `$LOADED_FEATURES` elements are not all of the "internal" strings.
* These should be in the file system, may not be UTF-8.

----------------------------------------
Bug #18191: All loaded feature filenames should be in the file system encoding
https://bugs.ruby-lang.org/issues/18191#change-93929

* Author: NuriYuri (Youri Nouri)
* Status: Open
* Priority: Normal
* Backport: 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED
----------------------------------------
I don't know if that has already been fixed but it seems that few internal variables ($LOADED_FEATURES) are still containing paths announced as BINARY instead of UTF-8. (While their content is actually UTF-8 Data).

Here's some evidence of the issue:
https://www.zupimages.net/up/21/38/g8a0.png
```
p $LOADED_FEATURES[5]
=> "D:/nuriy/Work/pok\xC3\xA9monsdk/lib/ruby/3.0.0/i386-mingw32/enc/encdb.so"
p $LOADED_FEATURES[5].encoding
=> #<Encoding:ASCII-8BIT>
```

Here's the fix I made to prevent the issue: https://gitlab.com/pokemonsdk/pokemonsdk/-/commit/c9b27ecad1c4b5016e2ef56a3f1df25e74395ce4
I believe that it can be fixed by setting the right encoding in the generated string object when $LOADED_FEATURES is filled.

ruby -v: `ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [i386-mingw32]`
Content of psdk.bat: `ruby.exe --disable=gems,rubyopt,did_you_mean Game.rb %*`



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:105612] [Ruby master Bug#18191] All loaded feature filenames should be in the file system encoding
  2021-09-25  8:23 [ruby-core:105416] [Ruby master Misc#18191] All internal filenames should be in UTF-8 NuriYuri (Youri Nouri)
  2021-09-29  1:28 ` [ruby-core:105480] [Ruby master Bug#18191] All loaded feature filenames should be in the file system encoding nobu (Nobuyoshi Nakada)
@ 2021-10-09  6:37 ` nagachika (Tomoyuki Chikanaga)
  1 sibling, 0 replies; 3+ messages in thread
From: nagachika (Tomoyuki Chikanaga) @ 2021-10-09  6:37 UTC (permalink / raw)
  To: ruby-core

Issue #18191 has been updated by nagachika (Tomoyuki Chikanaga).

Backport changed from 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED to 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: DONE

ruby_3_0 2c947e74a0a11fe6c54253c15224dc80054c62a2 merged revision(s) 60d0421ca861944459f52292d65dbf0ece26e38a,b6534691a16d751d59fc572d5dddebcaeb21f007,409dbc951b9875d27bd73748c88e15386473cffb,842b0008c132dd587f09766a228041afb7fed24f.

----------------------------------------
Bug #18191: All loaded feature filenames should be in the file system encoding
https://bugs.ruby-lang.org/issues/18191#change-94101

* Author: NuriYuri (Youri Nouri)
* Status: Closed
* Priority: Normal
* Backport: 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: DONE
----------------------------------------
I don't know if that has already been fixed but it seems that few internal variables ($LOADED_FEATURES) are still containing paths announced as BINARY instead of UTF-8. (While their content is actually UTF-8 Data).

Here's some evidence of the issue:
https://www.zupimages.net/up/21/38/g8a0.png
```
p $LOADED_FEATURES[5]
=> "D:/nuriy/Work/pok\xC3\xA9monsdk/lib/ruby/3.0.0/i386-mingw32/enc/encdb.so"
p $LOADED_FEATURES[5].encoding
=> #<Encoding:ASCII-8BIT>
```

Here's the fix I made to prevent the issue: https://gitlab.com/pokemonsdk/pokemonsdk/-/commit/c9b27ecad1c4b5016e2ef56a3f1df25e74395ce4
I believe that it can be fixed by setting the right encoding in the generated string object when $LOADED_FEATURES is filled.

ruby -v: `ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [i386-mingw32]`
Content of psdk.bat: `ruby.exe --disable=gems,rubyopt,did_you_mean Game.rb %*`



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-09  6:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-25  8:23 [ruby-core:105416] [Ruby master Misc#18191] All internal filenames should be in UTF-8 NuriYuri (Youri Nouri)
2021-09-29  1:28 ` [ruby-core:105480] [Ruby master Bug#18191] All loaded feature filenames should be in the file system encoding nobu (Nobuyoshi Nakada)
2021-10-09  6:37 ` [ruby-core:105612] " nagachika (Tomoyuki Chikanaga)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).