ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "nobu (Nobuyoshi Nakada)" <noreply@ruby-lang.org>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:105480] [Ruby master Bug#18191] All loaded feature filenames should be in the file system encoding
Date: Wed, 29 Sep 2021 01:28:38 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-93929.20210929012838.28052@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-18191.20210925082348.28052@ruby-lang.org

Issue #18191 has been updated by nobu (Nobuyoshi Nakada).

Subject changed from All internal filenames should be in UTF-8 to All loaded feature filenames should be in the file system encoding

* `$LOADED_FEATURES` elements are not all of the "internal" strings.
* These should be in the file system, may not be UTF-8.

----------------------------------------
Bug #18191: All loaded feature filenames should be in the file system encoding
https://bugs.ruby-lang.org/issues/18191#change-93929

* Author: NuriYuri (Youri Nouri)
* Status: Open
* Priority: Normal
* Backport: 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED
----------------------------------------
I don't know if that has already been fixed but it seems that few internal variables ($LOADED_FEATURES) are still containing paths announced as BINARY instead of UTF-8. (While their content is actually UTF-8 Data).

Here's some evidence of the issue:
https://www.zupimages.net/up/21/38/g8a0.png
```
p $LOADED_FEATURES[5]
=> "D:/nuriy/Work/pok\xC3\xA9monsdk/lib/ruby/3.0.0/i386-mingw32/enc/encdb.so"
p $LOADED_FEATURES[5].encoding
=> #<Encoding:ASCII-8BIT>
```

Here's the fix I made to prevent the issue: https://gitlab.com/pokemonsdk/pokemonsdk/-/commit/c9b27ecad1c4b5016e2ef56a3f1df25e74395ce4
I believe that it can be fixed by setting the right encoding in the generated string object when $LOADED_FEATURES is filled.

ruby -v: `ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [i386-mingw32]`
Content of psdk.bat: `ruby.exe --disable=gems,rubyopt,did_you_mean Game.rb %*`



-- 
https://bugs.ruby-lang.org/

  reply	other threads:[~2021-09-29  1:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25  8:23 [ruby-core:105416] [Ruby master Misc#18191] All internal filenames should be in UTF-8 NuriYuri (Youri Nouri)
2021-09-29  1:28 ` nobu (Nobuyoshi Nakada) [this message]
2021-10-09  6:37 ` [ruby-core:105612] [Ruby master Bug#18191] All loaded feature filenames should be in the file system encoding nagachika (Tomoyuki Chikanaga)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-93929.20210929012838.28052@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).