ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: takashikkbn@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:101902] [Ruby master Feature#17490] Rename RubyVM::MJIT to RubyVM::JIT
Date: Mon, 04 Jan 2021 04:50:08 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-89742.20210104045007.10073@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17490.20201230054510.10073@ruby-lang.org

Issue #17490 has been updated by k0kubun (Takashi Kokubun).


This thread is already too long for off topics, so let me focus on the name of `RubyVM::MJIT` in this ticket and leave the release notes discussion to elsewhere.

> I don't see why an internal/experimental module (RubyVM::MJIT) need to have name understandable by people knowing nothing about MJIT.
> I'd say users of RubyVM::MJIT should at least know the name of the JIT before using those APIs.

If the feature will continue to be MJIT-specific, your point would make sense. But as I'm trying to make `--jit` and `RubyVM::MJIT` consistent in terms of their name, I think their feature should also be consistent; `RubyVM::MJIT.pause/resume` should control not only MJIT but also other JITs if `--jit` is going to enable all future tiers of JIT. I think the number of JIT-relaed APIs should be as few as possible, and this change will contribute to limiting per-JIT features, i.e. I don't want `RubyVM::YetAnotherJIT` in the future. 

By the way, let me point out again that this feature is mainly for MJIT's development / testing and not for people who don't contribute to developing MJIT. Please don't take my development time away for discussing this if you only care about TruffleRuby's compatibility with modules under RubyVM, because clearly there's no need to do so.

----------------------------------------
Feature #17490: Rename RubyVM::MJIT to RubyVM::JIT
https://bugs.ruby-lang.org/issues/17490#change-89742

* Author: k0kubun (Takashi Kokubun)
* Status: Open
* Priority: Normal
----------------------------------------
## Background
In my understanding, MJIT is a codename like YARV which many people outside Ruby community are not familiar with, so I've used JIT in NEWS or release notes to avoid explaining the "M" part whenever we release a new version. However, because we have the name "MJIT" in one of our constants, we've had some naming inconsistency. For instance, --jit is not --mjit and it's not consistent.

## Proposal
Have the same constant as `RubyVM::JIT`, deprecate `RubyVM::MJIT` from Ruby 3.1, and remove the old one in Ruby 3.2.

## Impact
This impacts only [Feature #14830] `RubyVM::MJIT.pause` / `RubyVM::MJIT.resume`, which is basically for k0kubun's own testing.



-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2021-01-04  4:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30  5:45 [ruby-core:101809] [Ruby master Feature#17490] Rename RubyVM::MJIT to RubyVM::JIT takashikkbn
2020-12-30 15:05 ` [ruby-core:101812] " eregontp
2020-12-30 22:59 ` [ruby-core:101821] " nobu
2020-12-31  7:47 ` [ruby-core:101832] " takashikkbn
2020-12-31  8:05 ` [ruby-core:101833] " hsbt
2021-01-01 12:20 ` [ruby-core:101851] " eregontp
2021-01-01 12:48 ` [ruby-core:101853] " eregontp
2021-01-02  3:06 ` [ruby-core:101874] " takashikkbn
2021-01-02 12:50 ` [ruby-core:101879] " eregontp
2021-01-02 15:51 ` [ruby-core:101880] " takashikkbn
2021-01-03 13:28 ` [ruby-core:101886] " eregontp
2021-01-04  4:50 ` takashikkbn [this message]
2021-01-13  6:29 ` [ruby-core:102051] " matz
2022-01-17  6:00 ` [ruby-core:107154] " znz (Kazuhiro NISHIYAMA)
2022-01-17  6:32 ` [ruby-core:107155] " k0kubun (Takashi Kokubun)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-89742.20210104045007.10073@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).